Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3449)

Issue 143830044: code review 143830044: net: separate NaCl dependent placeholders from BSD's (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by mikio
Modified:
10 years, 6 months ago
Reviewers:
adg, rsc
CC:
golang-codereviews, adg
Visibility:
Public.

Description

net: separate NaCl dependent placeholders from BSD's To clarify the dependency of NaCl platform.

Patch Set 1 : diff -r 6e76bf4838e34814288ed3596a6d0792119c4684 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r cb1c0e8fc75d3e7706412701b765143880ea0196 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -290 lines) Patch
M src/net/dial_test.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/net/dnsclient_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/dnsconfig_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/file_stub.go View 4 chunks +6 lines, -107 lines 0 comments Download
M src/net/file_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/file_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/ipraw_test.go View 1 chunk +5 lines, -0 lines 0 comments Download
M src/net/lookup_stub.go View 1 chunk +18 lines, -137 lines 0 comments Download
M src/net/lookup_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/port_test.go View 2 chunks +6 lines, -0 lines 0 comments Download
M src/net/port_unix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/sock_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/sock_stub.go View 1 chunk +2 lines, -0 lines 0 comments Download
M src/net/sockopt_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/sockopt_posix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/sockopt_stub.go View 1 chunk +22 lines, -17 lines 0 comments Download
M src/net/sockoptip_bsd.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/sockoptip_posix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/sockoptip_stub.go View 2 chunks +7 lines, -7 lines 0 comments Download
M src/net/tcpsockopt_openbsd.go View 2 chunks +2 lines, -4 lines 0 comments Download
M src/net/tcpsockopt_posix.go View 1 chunk +1 line, -1 line 0 comments Download
M src/net/tcpsockopt_stub.go View 2 chunks +6 lines, -4 lines 0 comments Download
M src/os/exec/exec_test.go View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2014-09-12 16:01:20 UTC) #1
mikio
ping
10 years, 6 months ago (2014-09-18 09:40:36 UTC) #2
adg
It looks like a reasonable step to me, but can you clarify how this "preserves ...
10 years, 6 months ago (2014-09-18 09:45:18 UTC) #3
mikio
On Thu, Sep 18, 2014 at 6:45 PM, <adg@golang.org> wrote: > It looks like a ...
10 years, 6 months ago (2014-09-18 09:48:24 UTC) #4
adg
LGTM
10 years, 6 months ago (2014-09-18 09:54:34 UTC) #5
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=cbf74e78998f *** net: separate NaCl dependent placeholders from BSD's To clarify the ...
10 years, 6 months ago (2014-09-18 10:20:22 UTC) #6
rsc
10 years, 6 months ago (2014-09-18 17:20:35 UTC) #7
Message was sent while issue was closed.
What bug did this fix?
We are in a release freeze.
Please do not do reorgs or refactorings.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b