Issue 14369043: code review 14369043: cmd/go: add any .c/.cc files to the SWIG shared library

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14369043: code review 14369043: cmd/go: add any .c/.cc files to the SWIG shared library (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by iant

Modified:
10 years, 6 months ago

Reviewers:
minux1

CC:
golang-dev, minux1

Visibility:
Public.

Description

cmd/go: add any .c/.cc files to the SWIG shared library Also add the action's object directory to the list of directories we use to find SWIG shared libraries. Fixes issue 6521.

Patch Set 1 #

Patch Set 2 : diff -r 1e39b9482377 https://code.google.com/p/go #

Patch Set 3 : diff -r b696837bda3e https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -12 lines)			Patch
M	misc/swig/callback/callback.h	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
A	misc/swig/callback/callback.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/cmd/go/build.go	View		8 chunks	+34 lines, -7 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2013-10-03 23:46:33 UTC) #1

iant

PTAL Modified misc/swig/callback to serve as an example. "go test" in that directory will work, ...

10 years, 6 months ago (2013-10-09 15:40:33 UTC) #4

iant

10 years, 6 months ago (2013-10-09 17:35:49 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=ebb2ba0fe943 ***

cmd/go: add any .c/.cc files to the SWIG shared library

Also add the action's object directory to the list of
directories we use to find SWIG shared libraries.

Fixes issue 6521.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/14369043

Expand All Messages | Collapse All Messages