Issue 143610043: code review 143610043: go.image/vp8l: follow the default code length.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 143610043: code review 143610043: go.image/vp8l: follow the default code length. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
r, skal, golang-codereviews

Visibility:
Public.

Description

go.image/vp8l: use the default code length for repeated codes. This fixes the lossless_vec_2_13.webp conformance test.

Patch Set 2 : diff -r 250a212e718aa7084d77870efe8eba3702657b99 https://code.google.com/p/go.image #

Patch Set 3 : diff -r 250a212e718aa7084d77870efe8eba3702657b99 https://code.google.com/p/go.image #

Patch Set 4 : diff -r 250a212e718aa7084d77870efe8eba3702657b99 https://code.google.com/p/go.image #

Patch Set 5 : diff -r 250a212e718aa7084d77870efe8eba3702657b99 https://code.google.com/p/go.image #

Total comments: 2

Patch Set 6 : diff -r 250a212e718aa7084d77870efe8eba3702657b99 https://code.google.com/p/go.image #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	vp8l/decode.go	View	1 2 3 4	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-codereviews@googlegroups.com, pascal.massimino@gmail.com), I'd like you to review this change to https://code.google.com/p/go.image

9 years, 7 months ago (2014-09-25 06:42:28 UTC) #1

skal

https://codereview.appspot.com/143610043/diff/80001/vp8l/decode.go File vp8l/decode.go (right): https://codereview.appspot.com/143610043/diff/80001/vp8l/decode.go#newcode183 vp8l/decode.go:183: // The spec says that "if code 16 [meaning ...

9 years, 7 months ago (2014-09-25 07:33:51 UTC) #2

nigeltao

9 years, 7 months ago (2014-09-26 01:08:16 UTC) #4

nigeltao

9 years, 7 months ago (2014-09-26 01:09:16 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=7a8e25916961&repo=image ***

go.image/vp8l: use the default code length for repeated codes.

This fixes the lossless_vec_2_13.webp conformance test.

LGTM=r
R=r, pascal.massimino
CC=golang-codereviews
https://codereview.appspot.com/143610043

Expand All Messages | Collapse All Messages