Issue 1435041: code review 1435041: vector: undo changes to autogenerated files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1435041: code review 1435041: vector: undo changes to autogenerated files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by fhs

Modified:
14 years, 9 months ago

Reviewers:

CC:
r, golang-dev, hoisie

Visibility:
Public.

Description

vector: undo changes to autogenerated files Also, move Do() to vector.go, so that Do() for IntVector and StringVector is autogenerated. The only files edited are Makefile, defs.go, and vector.go. The rest are autogenerated with "make generate".

Patch Set 1 #

Patch Set 2 : code review 1435041: vector: undo changes to autogenerated files #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -42 lines)			Patch
M	src/pkg/container/vector/Makefile	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/container/vector/defs.go	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	src/pkg/container/vector/intvector.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/container/vector/intvector_test.go	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	src/pkg/container/vector/stringvector.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/container/vector/stringvector_test.go	View	3 chunks	+12 lines, -9 lines	0 comments	Download
M	src/pkg/container/vector/vector.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fhs

Hello r (cc: golang-dev@googlegroups.com, hoisie), I'd like you to review this change.

14 years, 9 months ago (2010-05-31 22:42:42 UTC) #1

14 years, 9 months ago (2010-05-31 22:54:03 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=52a50509b83b ***

vector: undo changes to autogenerated files

Also, move Do() to vector.go, so that Do() for IntVector and StringVector
is autogenerated.

The only files edited are Makefile, defs.go, and vector.go. The rest are
autogenerated with "make generate".

R=r
CC=golang-dev, hoisie
http://codereview.appspot.com/1435041

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages