Issue 143160043: code review 143160043: os/signal: increase timeout from 10ms to 100ms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 143160043: code review 143160043: os/signal: increase timeout from 10ms to 100ms (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews

Visibility:
Public.

Description

os/signal: increase timeout from 10ms to 100ms Might make test less flaky. Fixes issue 8682.

Patch Set 1 #

Patch Set 2 : diff -r d4fc8b60c5446b9f5fb9572f86ad5af1e426b261 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d4fc8b60c5446b9f5fb9572f86ad5af1e426b261 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ab3588ba2386c8f1275eba5466236494f6e3bd47 https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/os/signal/signal_test.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-16 18:58:13 UTC) #1

rsc

9 years, 7 months ago (2014-09-16 19:26:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=6f0c89b41b3d ***

os/signal: increase timeout from 10ms to 100ms

Might make test less flaky.
Fixes issue 8682.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://codereview.appspot.com/143160043

Expand All Messages | Collapse All Messages