Issue 143100043: code review 143100043: io: clarify Reader returning 0, nil

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 143100043: code review 143100043: io: clarify Reader returning 0, nil (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
r, bradfitz

CC:
bradfitz, iant, golang-codereviews

Visibility:
Public.

Description

io: clarify Reader returning 0, nil Fixes issue 8317.

Patch Set 2 : diff -r b2eb00e46b33b62701a225c329d82181b084baca https://code.google.com/p/go/ #

Patch Set 3 : diff -r b2eb00e46b33b62701a225c329d82181b084baca https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 7c7e3651df70de69986cd2a45a4be5c73c55c462 https://code.google.com/p/go/ #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/io/io.go	View	1 2 3	1 chunk	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz, iant, r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-15 17:09:26 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/143100043/diff/40001/src/io/io.go File src/io/io.go (right): https://codereview.appspot.com/143100043/diff/40001/src/io/io.go#newcode69 src/io/io.go:69: // Implementations must not retain references to p's ...

9 years, 7 months ago (2014-09-15 17:12:02 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=9fd6643ae601 *** io: clarify Reader returning 0, nil Fixes issue 8317. LGTM=bradfitz ...

9 years, 7 months ago (2014-09-16 14:01:32 UTC) #4

9 years, 7 months ago (2014-09-16 16:02:18 UTC) #5

Message was sent while issue was closed.

https://codereview.appspot.com/143100043/diff/60001/src/io/io.go
File src/io/io.go (right):

https://codereview.appspot.com/143100043/diff/60001/src/io/io.go#newcode66
src/io/io.go:66: // Callers should treat a return of 0 and nil as indicating
that
i would prefer "a return of (0, nil)" but it's not important. it's bad grammar
either way.

Expand All Messages | Collapse All Messages