Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(574)

Issue 142770043: code review 142770043: go.benchmarks: fix garbage benchmark after src/pkg change (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dfc
Modified:
9 years, 6 months ago
Reviewers:
bradfitz
CC:
dvyukov, adg, bradfitz, golang-codereviews
Visibility:
Public.

Description

go.benchmarks: fix garbage benchmark after src/pkg change Possibly this code should use go/imports, but this should get the benchmark working again.

Patch Set 1 #

Patch Set 2 : diff -r a56e45af2aa713fbe5e064edfeba4a73909853b4 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r a56e45af2aa713fbe5e064edfeba4a73909853b4 https://code.google.com/p/go.benchmarks #

Patch Set 4 : diff -r a56e45af2aa713fbe5e064edfeba4a73909853b4 https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M garbage/garbage.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dfc
Hello dvyukov@google.com, adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks
9 years, 6 months ago (2014-09-08 23:24:48 UTC) #1
bradfitz
LGTM On Mon, Sep 8, 2014 at 4:24 PM, <dave@cheney.net> wrote: > Reviewers: dvyukov, adg, ...
9 years, 6 months ago (2014-09-08 23:25:12 UTC) #2
dfc
9 years, 6 months ago (2014-09-08 23:32:09 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=b9df84379b1b&repo=benchmarks ***

go.benchmarks: fix garbage benchmark after src/pkg change

Possibly this code should use go/imports, but this should get the benchmark
working again.

LGTM=bradfitz
R=dvyukov, adg, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/142770043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b