Issue 142690043: code review 142690043: [release-branch.go1.3] runtime: keep g->syscallsp consi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 142690043: code review 142690043: [release-branch.go1.3] runtime: keep g->syscallsp consi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by rsc

Modified:
9 years, 6 months ago

Reviewers:
gobot, adg, iant

CC:
iant, marcan, adg, dvyukov, golang-codereviews, r

Visibility:
Public.

Description

[release-branch.go1.3] runtime: keep g->syscallsp consistent after cgo->Go callbacks This is a manual backport of CL 131910043 to the Go 1.3 release branch. We believe this CL can cause arbitrary corruption in programs that call into C from Go and then call back into Go from C. This change will be released in Go 1.3.2.

Patch Set 1 #

Patch Set 2 : diff -r 4b852be63380 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4b852be63380 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4b852be63380 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 3106a8c415f2 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -6 lines)			Patch
M	misc/cgo/test/cgo_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	misc/cgo/test/issue7978.go	View	1 chunk	+103 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgocall.c	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/runtime/proc.c	View	5 chunks	+15 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/run.bash	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/run.bat	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: adg, dvyukov, golang-codereviews@googlegroups.com, marcan, r), I'd like you to review this change ...

9 years, 6 months ago (2014-09-25 17:46:53 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=dbfa622abde5 *** [release-branch.go1.3] runtime: keep g->syscallsp consistent after cgo->Go callbacks This is ...

9 years, 6 months ago (2014-09-25 22:07:07 UTC) #5

gobot

9 years, 6 months ago (2014-09-29 03:34:18 UTC) #6

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/cd7920a4d006c6422f7e97d4b2fcfa94913d932e

Expand All Messages | Collapse All Messages