Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1446)

Issue 14193043: code review 14193043: go.tools/godoc: move redirect helpers to new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by adg
Modified:
10 years, 6 months ago
Reviewers:
dsymonds
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

go.tools/godoc: move redirect helpers to new package Update issue 6512

Patch Set 1 #

Patch Set 2 : diff -r 3afab15d549e https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 3afab15d549e https://code.google.com/p/go.tools #

Total comments: 6

Patch Set 4 : diff -r 3afab15d549e https://code.google.com/p/go.tools #

Patch Set 5 : diff -r cc9b5c2d3739 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -208 lines) Patch
M cmd/godoc/blog.go View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M cmd/godoc/codewalk.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/godoc/handlers.go View 1 3 chunks +1 line, -132 lines 0 comments Download
M godoc/redirect/redirect.go View 1 2 3 3 chunks +11 lines, -70 lines 0 comments Download

Messages

Total messages: 4
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 6 months ago (2013-10-01 05:33:57 UTC) #1
dsymonds
LGTM https://codereview.appspot.com/14193043/diff/3001/cmd/godoc/codewalk.go File cmd/godoc/codewalk.go (right): https://codereview.appspot.com/14193043/diff/3001/cmd/godoc/codewalk.go#newcode85 cmd/godoc/codewalk.go:85: func doRedirect(w http.ResponseWriter, r *http.Request) (redirected bool) { ...
10 years, 6 months ago (2013-10-01 06:00:06 UTC) #2
adg
PTAL https://codereview.appspot.com/14193043/diff/3001/cmd/godoc/codewalk.go File cmd/godoc/codewalk.go (right): https://codereview.appspot.com/14193043/diff/3001/cmd/godoc/codewalk.go#newcode85 cmd/godoc/codewalk.go:85: func doRedirect(w http.ResponseWriter, r *http.Request) (redirected bool) { ...
10 years, 6 months ago (2013-10-01 06:27:23 UTC) #3
adg
10 years, 6 months ago (2013-10-01 06:32:21 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=0df93e193586&repo=tools ***

go.tools/godoc: move redirect helpers to new package

Update issue 6512

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/14193043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b