Issue 14188044: cmd/gc: qualified embedded fields with owner package.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14188044: cmd/gc: qualified embedded fields with owner package.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by remyoudompheng

Modified:
10 years, 6 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/gc: qualified embedded fields with owner package.

Patch Set 1 #

Patch Set 2 : diff -r 664c8763de42 https://code.google.com/p/go #

Patch Set 3 : diff -r 664c8763de42 https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2139 lines, -1435 lines)			Patch
M	src/cmd/gc/dcl.c	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/cmd/gc/fmt.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/go.y	View	1	4 chunks	+21 lines, -4 lines	0 comments	Download
M	src/cmd/gc/y.tab.h	View	1	3 chunks	+25 lines, -21 lines	0 comments	Download
M	src/cmd/gc/y.tab.c	View	1	222 chunks	+2028 lines, -1390 lines	0 comments	Download
M	src/cmd/gc/yerr.h	View	1	2 chunks	+15 lines, -15 lines	0 comments	Download
A	test/fixedbugs/issue6513.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue6513.dir/a.go	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue6513.dir/b.go	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue6513.dir/main.go	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

10 years, 6 months ago (2013-10-02 16:27:38 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=f280b8a485fd ***

cmd/gc: qualified embedded fields with owner package.

R=rsc
CC=golang-dev
https://codereview.appspot.com/14188044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages