Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 14169043: code review 14169043: go.talks: compile all code in editable code snippets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by adg
Modified:
10 years, 7 months ago
Reviewers:
r, dsymonds
CC:
dsymonds, golang-dev
Visibility:
Public.

Description

go.talks: compile all code in editable code snippets Some elements of the DOM were being skipped over because the existing algorithm assumed all the code was inside SPAN tags. The browser "contenteditable" feature introduces DIVs and probably other things. The new algorithm is more liberal in what it accepts.

Patch Set 1 #

Patch Set 2 : diff -r aaae64d69b11 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M present/js/play.js View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4
adg
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 7 months ago (2013-09-30 23:46:29 UTC) #1
dsymonds
LGTM
10 years, 7 months ago (2013-10-01 00:41:20 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=ade19922d5e7&repo=talks *** go.talks: compile all code in editable code snippets Some elements ...
10 years, 7 months ago (2013-10-01 00:42:18 UTC) #3
r
10 years, 7 months ago (2013-10-01 00:55:02 UTC) #4
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b