code review 141600043: syscall: mark ECONNRESET, ECONNABORTED as temporary net...

syscall: mark ECONNRESET, ECONNABORTED as temporary network errors

Fixes issue 6163.

[rsc, 2014-09-19 02:44:19]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[adg, 2014-09-19 02:46:21]

LGTM

[dvyukov, 2014-09-19 02:47:52]

read and recv also return ECONNRESET, in which case it is not temporal
you seem to be assuming that Temporary applies only to accept call

On Thu, Sep 18, 2014 at 7:45 PM, Andrew Gerrand <adg@golang.org> wrote:
> LGTM
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[rsc, 2014-09-19 03:06:47]

i am assuming that it will fix the bug report.
i am not assuming that it will not create other bugs.
but i am assuming that we will get those reports if so and can revisit then.
sockets are an abomination.

russ

[rsc, 2014-09-19 03:07:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=78887283a01a ***

syscall: mark ECONNRESET, ECONNABORTED as temporary network errors

Fixes issue 6163.

LGTM=adg
R=golang-codereviews, adg, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/141600043