Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2197)

Issue 141290043: code review 141290043: undo CL 142770043 / b9df84379b1b (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dave
Modified:
9 years, 7 months ago
Reviewers:
dvyukov
CC:
dvyukov, golang-codereviews
Visibility:
Public.

Description

undo CL 142770043 / b9df84379b1b Benchmark builds prior to CL 134570043 will fail. ««« original CL description go.benchmarks: fix garbage benchmark after src/pkg change Possibly this code should use go/imports, but this should get the benchmark working again. LGTM=bradfitz R=dvyukov, adg, bradfitz CC=golang-codereviews https://codereview.appspot.com/142770043 »»»

Patch Set 1 #

Patch Set 2 : diff -r b9df84379b1b783ffd5e2dca793ef5b238055f1a https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r b9df84379b1b783ffd5e2dca793ef5b238055f1a https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M garbage/garbage.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
dave_cheney.net
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.benchmarks
9 years, 7 months ago (2014-09-09 05:10:28 UTC) #1
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=f53d6ffd4ae2&repo=benchmarks *** undo CL 142770043 / b9df84379b1b Benchmark builds prior to CL ...
9 years, 7 months ago (2014-09-09 05:12:15 UTC) #2
dvyukov
9 years, 7 months ago (2014-09-09 15:49:19 UTC) #3
lgtm

On Tue, Sep 9, 2014 at 9:12 AM,  <dave@cheney.net> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=f53d6ffd4ae2&repo=benchmarks
> ***
>
> undo CL 142770043 / b9df84379b1b
>
> Benchmark builds prior to CL 134570043 will fail.
>
> ««« original CL description
> go.benchmarks: fix garbage benchmark after src/pkg change
>
> Possibly this code should use go/imports, but this should get the
> benchmark working again.
>
> LGTM=bradfitz
> R=dvyukov, adg, bradfitz
> CC=golang-codereviews
> https://codereview.appspot.com/142770043
> »»»
>
> TBR=dvyukov
> R=golang-codereviews
> CC=golang-codereviews
> https://codereview.appspot.com/141290043
>
>
> https://codereview.appspot.com/141290043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b