Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3450)

Issue 140460044: code review 140460044: runtime: stop plan9/amd64 build from crashing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by ality
Modified:
10 years, 6 months ago
Reviewers:
iant
CC:
rsc, 0intro, brainman, iant, golang-codereviews
Visibility:
Public.

Description

runtime: stop plan9/amd64 build from crashing

Patch Set 1 #

Patch Set 2 : diff -r ef6b41b270d58a842faf37b77a90a92a61cc6cd1 https://code.google.com/p/go #

Patch Set 3 : diff -r ef6b41b270d58a842faf37b77a90a92a61cc6cd1 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/runtime/asm_amd64.s View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
ality
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2014-09-10 09:26:12 UTC) #1
ality
This will probably also fix the windows/amd64 build. If anyone wants the writeup of how ...
10 years, 6 months ago (2014-09-10 09:30:04 UTC) #2
0intro
> This will probably also fix the windows/amd64 build. > > If anyone wants the ...
10 years, 6 months ago (2014-09-10 10:02:49 UTC) #3
brainman
I think it will. Alex
10 years, 6 months ago (2014-09-10 10:24:33 UTC) #4
brainman
It does fixes windows-amd64 build. Alex
10 years, 6 months ago (2014-09-10 11:33:58 UTC) #5
iant
LGTM
10 years, 6 months ago (2014-09-10 13:21:54 UTC) #6
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=ca2c8c76aed9 *** runtime: stop plan9/amd64 build from crashing LGTM=iant R=rsc, 0intro, alex.brainman, ...
10 years, 6 months ago (2014-09-10 13:25:10 UTC) #7
rsc
10 years, 6 months ago (2014-09-10 15:22:19 UTC) #8
Fantastic, thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b