Issue 14035044: code review 14035044: reflect: Implement MakeFunc for 386.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14035044: code review 14035044: reflect: Implement MakeFunc for 386. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by iant

Modified:
11 years, 5 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

reflect: Implement MakeFunc for 386.

Patch Set 1 #

Patch Set 2 : diff -r 14a32fb52e24 https://gofrontend.googlecode.com/hg/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -5 lines)			Patch
M	libgo/Makefile.am	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	libgo/Makefile.in	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	libgo/go/reflect/all_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	libgo/go/reflect/makefunc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
A	libgo/go/reflect/makefunc_386.S	View		1 chunk	+111 lines, -0 lines	0 comments	Download
A	libgo/go/reflect/makefuncgo_386.go	View	1	1 chunk	+135 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

11 years, 5 months ago (2013-09-27 21:31:03 UTC) #1

iant

11 years, 5 months ago (2013-09-27 21:31:15 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=cec0db170d82 ***

reflect: Implement MakeFunc for 386.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/14035044

Expand All Messages | Collapse All Messages