Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1577)

Issue 13887043: code review 13887043: cmd/dist, build: support building statically linked too... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by minux1
Modified:
10 years, 6 months ago
Reviewers:
adg, rsc
CC:
adg, rsc, iant, golang-dev
Visibility:
Public.

Description

cmd/dist, build: support building statically linked toolchain Added a new $GO_DISTFLAGS to make.bash, and while we're here, added mention $CXX in make.bash (CL 13704044). Fixes issue 6448. Update issue 3564 We can pass GO_DISTFLAGS=-s from misc/dist to make.bash so that it will build a statically linked toolchain. (Note: OS X doesn't have the concept of static linking, so don't pass GO_DISTFLAGS=-s for OS X builds)

Patch Set 1 #

Patch Set 2 : diff -r 3a322810a773 https://code.google.com/p/go #

Patch Set 3 : diff -r 3a322810a773 https://code.google.com/p/go #

Patch Set 4 : diff -r f36d5f776715 https://code.google.com/p/go #

Patch Set 5 : diff -r f36d5f776715 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/cmd/dist/a.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/dist/build.c View 1 3 chunks +8 lines, -0 lines 0 comments Download
M src/cmd/dist/main.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/make.bash View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 7 months ago (2013-09-25 02:43:07 UTC) #1
adg
Mention in the CL description that this introduces two new environment variables for make.bash. Also ...
10 years, 7 months ago (2013-09-25 05:03:14 UTC) #2
minux1
PTAL. On 2013/09/25 05:03:14, adg wrote: > Mention in the CL description that this introduces ...
10 years, 6 months ago (2013-09-25 16:19:34 UTC) #3
adg
LGTM But wait for iant or rsc.
10 years, 6 months ago (2013-09-26 02:02:08 UTC) #4
rsc
LGTM
10 years, 6 months ago (2013-10-02 00:25:32 UTC) #5
minux1
10 years, 6 months ago (2013-10-02 03:44:27 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=4971493b0e14 ***

cmd/dist, build: support building statically linked toolchain

Added a new $GO_DISTFLAGS to make.bash, and while we're here,
added mention $CXX in make.bash (CL 13704044).

Fixes issue 6448.
Update issue 3564
We can pass GO_DISTFLAGS=-s from misc/dist to make.bash so that
it will build a statically linked toolchain.
(Note: OS X doesn't have the concept of static linking, so don't
pass GO_DISTFLAGS=-s for OS X builds)

R=adg, rsc, iant
CC=golang-dev
https://codereview.appspot.com/13887043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b