Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Issue 138840044: code review 138840044: undo CL 107150043 / caa2646daa63 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by mikio
Modified:
10 years, 6 months ago
Reviewers:
worr, gobot, r
CC:
r, iant, golang-codereviews
Visibility:
Public.

Description

undo CL 107150043 / caa2646daa63 preparing for the syscall package freeze. the change for issue 8218 is only applied to go.sys/unix. ««« original CL description syscall: implement setresuid(2) and setresgid(2) on OpenBSD/FreeBSD/DragonflyBSD Fixes issue 8218. LGTM=iant R=golang-codereviews, iant, minux CC=golang-codereviews https://codereview.appspot.com/107150043 Committer: Ian Lance Taylor <iant@golang.org> »»»

Patch Set 1 : diff -r 25c3a04e7b95fac3cfe0bb1cb7d10b577674ec63 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 0ddf9c344a598a05083f6f15bc22811bf8ec417b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -146 lines) Patch
M src/pkg/syscall/syscall_dragonfly.go View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_freebsd.go View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_openbsd.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/zsyscall_dragonfly_386.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_dragonfly_amd64.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_386.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_amd64.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_arm.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_386.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_amd64.go View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 8
mikio
Hello r@golang.org, iant@golang.org, golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2014-08-29 22:33:39 UTC) #1
r
LGTM
10 years, 6 months ago (2014-08-29 22:40:09 UTC) #2
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=12d4c082a491 *** undo CL 107150043 / caa2646daa63 preparing for the syscall package ...
10 years, 6 months ago (2014-08-29 22:52:50 UTC) #3
gobot
This CL appears to have broken the windows-amd64-perf builder. See http://build.golang.org/log/321f25cb21aaa1bb122fdfa08423075ebc56f55a
10 years, 6 months ago (2014-08-29 22:53:59 UTC) #4
worr
On 2014/08/29 22:52:50, mikio wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=12d4c082a491 *** > > undo CL ...
10 years, 6 months ago (2014-09-12 07:00:57 UTC) #5
mikio
On Fri, Sep 12, 2014 at 4:00 PM, <ay1244@gmail.com> wrote: > Will this change be ...
10 years, 6 months ago (2014-09-12 07:20:21 UTC) #6
worr
On 2014/09/12 07:20:21, mikio wrote: > On Fri, Sep 12, 2014 at 4:00 PM, <mailto:ay1244@gmail.com> ...
10 years, 6 months ago (2014-09-12 22:08:39 UTC) #7
r
10 years, 6 months ago (2014-09-16 19:46:40 UTC) #8
Yes please.

On Fri, Sep 12, 2014 at 3:08 PM,  <ay1244@gmail.com> wrote:
> On 2014/09/12 07:20:21, mikio wrote:
>
>> On Fri, Sep 12, 2014 at 4:00 PM,  <mailto:ay1244@gmail.com> wrote:
>
>
>> > Will this change be reapplied?I submitted the patch that this
>
> reverts
>>
>> > because I use these syscalls on OpenBSD.
>
>
>> that's unfortunate, see https://golang.org/s/go1.4-syscall
>> i also did revert a few patches i submitted, urgh. looks like
>> go.sys/unix has not been curated yet, hm.
>
>
> That is unfortunate.
>
> Should I draw up a patch for go.sys?
>
> https://codereview.appspot.com/138840044/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b