code review 138770043: cmd/{addr2line,objdump}: fix finding pclntab and symtab...

cmd/{addr2line,objdump}: fix finding pclntab and symtab for pe and plan9obj

Broken by 8b5fc7c59d05.

Update issue 8092

[mdempsky, 2014-08-28 00:36:24]

Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-08-28 00:42:48]

https://codereview.appspot.com/138770043/diff/40001/src/cmd/internal/objfile/...
File src/cmd/internal/objfile/pe.go (right):

https://codereview.appspot.com/138770043/diff/40001/src/cmd/internal/objfile/...
src/cmd/internal/objfile/pe.go:119: if pclntab, err = loadPETable(f.pe,
"pclntab", "epclntab"); err != nil {
If none of the symbols are found, we'll return the wrong error.  I think you
should use err2 inside the block, and then return err if err2 != nil.

Also please add a comment like

// We didn't find the symbols, so look for the names used in 1.3 and earlier.
// TODO: Remove code looking for the old symbols when we no longer care about
1.3.

Similar comments for the various other locations.

Thanks.

[brainman, 2014-08-28 00:48:48]

testing it now.

Alex

[mdempsky, 2014-08-28 00:51:50]

https://codereview.appspot.com/138770043/diff/40001/src/cmd/internal/objfile/...
File src/cmd/internal/objfile/pe.go (right):

https://codereview.appspot.com/138770043/diff/40001/src/cmd/internal/objfile/...
src/cmd/internal/objfile/pe.go:119: if pclntab, err = loadPETable(f.pe,
"pclntab", "epclntab"); err != nil {
On 2014/08/28 00:42:48, iant wrote:
> If none of the symbols are found, we'll return the wrong error.  I think you
> should use err2 inside the block, and then return err if err2 != nil.
> 
> Also please add a comment like
> 
> // We didn't find the symbols, so look for the names used in 1.3 and earlier.
> // TODO: Remove code looking for the old symbols when we no longer care about
> 1.3.
> 
> Similar comments for the various other locations.
> 
> Thanks.

Done.  PTAL and let me know if this is what you had in mind.

[iant, 2014-08-28 00:57:16]

LGTM

Thanks.

[brainman, 2014-08-28 01:00:47]

LGTM

Thank you. Submitting now.

Alex

[iant, 2014-08-28 01:01:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=14ab6d0208b6 ***

cmd/{addr2line,objdump}: fix finding pclntab and symtab for pe and plan9obj

Broken by 8b5fc7c59d05.

Update issue 8092

LGTM=iant, alex.brainman
R=rsc, iant, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/138770043

Committer: Ian Lance Taylor <iant@golang.org>

[gobot, 2014-08-28 01:09:33]

This CL appears to have broken the linux-386-387-temp builder.
See http://build.golang.org/log/67038552811b3578d1a526fc3a566c36f3655913

[mdempsky, 2014-08-28 01:15:31]

On Wed, Aug 27, 2014 at 6:09 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the linux-386-387-temp builder.
> See http://build.golang.org/log/67038552811b3578d1a526fc3a566c36f3655913


Broken builder?

write error: No space left on device

[brainman, 2014-08-28 01:24:22]

On 2014/08/28 01:15:31, mdempsky wrote:
> On Wed, Aug 27, 2014 at 6:09 PM, <mailto:gobot@golang.org> wrote:
> 
> > This CL appears to have broken the linux-386-387-temp builder.
> > See http://build.golang.org/log/67038552811b3578d1a526fc3a566c36f3655913
> 
> 
> Broken builder?
> 

Must be.

Alex

[bradfitz, 2014-08-28 01:26:14]

Yeah, all the -temp builders are still in development.

They're filling the docker copy-on-write filesystem thingy faster than it
can be cleaned or something.



On Wed, Aug 27, 2014 at 6:24 PM, <alex.brainman@gmail.com> wrote:

> On 2014/08/28 01:15:31, mdempsky wrote:
>
>  On Wed, Aug 27, 2014 at 6:09 PM, <mailto:gobot@golang.org> wrote:
>>
>
>  > This CL appears to have broken the linux-386-387-temp builder.
>> > See
>>
> http://build.golang.org/log/67038552811b3578d1a526fc3a566c36f3655913
>
>
>  Broken builder?
>>
>
>
> Must be.
>
> Alex
>
> https://codereview.appspot.com/138770043/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>