Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1013)

Issue 138730043: code review 138730043: runtime: fix solaris build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
aram
CC:
golang-codereviews
Visibility:
Public.

Description

runtime: fix solaris build nanotime1 is not a Go function and must not store its result at 0(FP). That overwrites some data owned by the caller.

Patch Set 1 #

Patch Set 2 : diff -r 28b7a2b36ff762dbd650858dabd86b877e274ebd https://code.google.com/p/go/ #

Patch Set 3 : diff -r 28b7a2b36ff762dbd650858dabd86b877e274ebd https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/runtime/sys_solaris_amd64.s View 1 4 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello aram (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2014-08-27 18:52:22 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=30698178519c *** runtime: fix solaris build nanotime1 is not a Go function ...
10 years, 6 months ago (2014-08-27 18:52:28 UTC) #2
aram
10 years, 6 months ago (2014-08-27 19:03:25 UTC) #3
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b