Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(554)

Issue 13864044: code review 13864044: go.tools/oracle: change -mode argument into subcommand. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by adonovan
Modified:
10 years, 7 months ago
Reviewers:
Dominik Honnef, r
CC:
crawshaw1, Dominik Honnef, r, golang-dev
Visibility:
Public.

Description

go.tools/oracle: change -mode argument into subcommand. e.g. "oracle callgraph <package>" Also: simplified error handling. Eliminated oracle.errorf because it prepends "file:line:col: " to the error message so the main function can't safely prepend "Error: ". The position wasn't interesting though: it was just -pos, more or less.

Patch Set 1 #

Patch Set 2 : diff -r 0e70d8af698a https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 0e70d8af698a https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 0e70d8af698a https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 0e70d8af698a https://code.google.com/p/go.tools #

Patch Set 6 : diff -r 0e70d8af698a https://code.google.com/p/go.tools #

Patch Set 7 : diff -r 6c079ecab95e https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -70 lines) Patch
M cmd/oracle/emacs-test.bash View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/oracle/main.go View 1 2 3 4 10 chunks +30 lines, -24 lines 0 comments Download
M cmd/oracle/oracle.el View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M cmd/oracle/oracle.vim View 1 1 chunk +6 lines, -6 lines 0 comments Download
M oracle/callees.go View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M oracle/callers.go View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M oracle/callstack.go View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M oracle/describe.go View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M oracle/freevars.go View 1 1 chunk +1 line, -1 line 0 comments Download
M oracle/oracle.go View 1 2 3 4 5 5 chunks +3 lines, -11 lines 0 comments Download
M oracle/peers.go View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M oracle/referrers.go View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M oracle/testdata/src/main/calls.golden View 1 2 3 4 5 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4
adonovan
Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
10 years, 7 months ago (2013-09-24 20:03:53 UTC) #1
Dominik Honnef
LGTM on the emacs front.
10 years, 7 months ago (2013-09-24 22:34:14 UTC) #2
r
LGTM but instead of errors.New i'd just use fmt.Errorf everywhere.
10 years, 7 months ago (2013-09-25 04:32:20 UTC) #3
adonovan
10 years, 7 months ago (2013-09-25 18:34:42 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=4c5f46cc7b9d&repo=tools ***

go.tools/oracle: change -mode argument into subcommand.

e.g. "oracle callgraph <package>"

Also: simplified error handling.
Eliminated oracle.errorf because it prepends "file:line:col: "
to the error message so the main function can't safely prepend "Error: ".
The position wasn't interesting though: it was just -pos, more or less.

R=crawshaw, dominik.honnef, r
CC=golang-dev
https://codereview.appspot.com/13864044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b