Issue 138600043: code review 138600043: image/gif: don't let the per-frame transparent index mo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 138600043: code review 138600043: image/gif: don't let the per-frame transparent index mo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 6 months ago

Reviewers:
r

CC:
r, golang-codereviews, james.jdunne_gmail.com

Visibility:
Public.

Description

image/gif: don't let the per-frame transparent index modify the global palette. Fixes issue 7993.

Patch Set 1 #

Patch Set 2 : diff -r 541f4c85dfedb06962ac2d88b3d3bf90d0dc6a53 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 541f4c85dfedb06962ac2d88b3d3bf90d0dc6a53 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 932fe22207465e6c4bcdae29f5c519ba069f8927 https://code.google.com/p/go/ #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -10 lines)			Patch
	M	src/image/gif/reader.go	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
	M	src/image/gif/reader_test.go	View	1	2 chunks	+55 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org (cc: golang-codereviews@googlegroups.com, james.jdunne@gmail.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-18 04:10:07 UTC) #1

nigeltao

9 years, 6 months ago (2014-09-22 04:30:01 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4c2e269181ea ***

image/gif: don't let the per-frame transparent index modify the global
palette.

Fixes issue 7993.

LGTM=r
R=r
CC=golang-codereviews, james.jdunne
https://codereview.appspot.com/138600043

Expand All Messages | Collapse All Messages