code review 13859043: sync/atomic: adjust for new runtime.cas64 prototype

sync/atomic: adjust for new runtime.cas64 prototype

[rsc, 2013-09-24 15:05:40]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[minux1, 2013-09-24 16:28:59]

LGTM. Thanks.

[josharian, 2013-09-24 16:50:08]

On 2013/09/24 15:05:40, rsc wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go/

Can't speak to the code, but the results LGTM.

[rsc, 2013-09-24 17:22:34]

Hello golang-dev@googlegroups.com, minux.ma@gmail.com, josharian@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-09-24 17:23:30]

I added a test explicitly running generalCAS64, so that we do not have to find a
machine configuration that actually falls back to that code in order to test it.
But I am not myself near an ARM machine. Can someone please try this CL? Any ARM
machine should do.

[josharian, 2013-09-24 18:13:06]

On 2013/09/24 17:23:30, rsc wrote:
> I added a test explicitly running generalCAS64, so that we do not have to find
a
> machine configuration that actually falls back to that code in order to test
it.
> But I am not myself near an ARM machine. Can someone please try this CL? Any
ARM
> machine should do.

Good idea.

LGTM; all tests pass for me on ARM, including TestGeneralCAS64 and
TestCompareAndSwapUint64.

[rsc, 2013-09-24 19:54:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=351b6fe0ae36 ***

sync/atomic: adjust for new runtime.cas64 prototype

R=golang-dev, minux.ma, josharian
CC=golang-dev
https://codereview.appspot.com/13859043