Issue 13829044: code review 13829044: go/build: add go1.2 build tag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13829044: code review 13829044: go/build: add go1.2 build tag

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by speter

Modified:
10 years, 7 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

go/build: add go1.2 build tag Fixes issue 6449.

Patch Set 1 #

Patch Set 2 : diff -r 00ff0c821b3f https://code.google.com/p/go #

Patch Set 3 : diff -r 00ff0c821b3f https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/go/build/build.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

speter

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2013-09-23 01:35:53 UTC) #1

speter

On 2013/09/23 01:44:28, adg wrote: > Please change the CL description to "Fixes issue 6449." ...

10 years, 7 months ago (2013-09-23 01:48:05 UTC) #3

adg

10 years, 7 months ago (2013-09-23 08:11:29 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=06c20cdf7bc0 ***

go/build: add go1.2 build tag

Fixes issue 6449.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/13829044

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages