Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1150)

Issue 138090043: code review 138090043: dashboard/env: add a cgo-disabled Linux builder (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by bradfitz
Modified:
9 years, 8 months ago
Reviewers:
adg, dave
CC:
adg, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

dashboard/env: add a cgo-disabled Linux builder I think this is all that's needed? Fixes Issue 4795

Patch Set 1 #

Patch Set 2 : diff -r 2aa3d1c892469f5dcd093d28be98977f56b744f1 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 2aa3d1c892469f5dcd093d28be98977f56b744f1 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r e86225c0893dfd004e941e68798d004a8db79db6 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M dashboard/coordinator/main.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello adg@golang.org, dave@cheney.net (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 8 months ago (2014-09-04 23:42:29 UTC) #1
adg
LGTM
9 years, 8 months ago (2014-09-04 23:50:06 UTC) #2
dave_cheney.net
LGTM. Woot! > On 5 Sep 2014, at 9:49, Andrew Gerrand <adg@golang.org> wrote: > > ...
9 years, 8 months ago (2014-09-04 23:51:12 UTC) #3
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=1192ca51f995&repo=tools *** dashboard/env: add a cgo-disabled Linux builder I think this is ...
9 years, 8 months ago (2014-09-04 23:58:40 UTC) #4
bradfitz
9 years, 8 months ago (2014-09-05 00:01:26 UTC) #5
And it's running:

http://107.178.219.46/

1 of max 6 builds running:
linux-amd64-nocgo      hg f66b158ba381e3ba3a20d3ad2bd05d82145d43ba in
container f51d0784e87c590494d70b6122e7ff86d2c9150da26b32970e0ff63bc381c618,
33.316661495s ago

http://107.178.219.46/logs?name=linux-amd64-nocgo&rev=f66b158ba381e3ba3a20d3a...




On Thu, Sep 4, 2014 at 4:58 PM, <bradfitz@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=1192ca51f995&repo=tools ***
>
>
> dashboard/env: add a cgo-disabled Linux builder
>
> I think this is all that's needed?
>
> Fixes Issue 4795
>
> LGTM=adg, dave
> R=adg, dave
> CC=golang-codereviews
> https://codereview.appspot.com/138090043
>
>
> https://codereview.appspot.com/138090043/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b