Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1206)

Issue 13798047: code review 13798047: go/build: handle $GOOS/$GOARCH matching in #cgo lines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by minux1
Modified:
10 years, 6 months ago
Reviewers:
rsc, slimsag, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

go/build: handle $GOOS/$GOARCH matching in #cgo lines. Fixes issue 6438.

Patch Set 1 #

Patch Set 2 : diff -r 62e67a664a03 https://code.google.com/p/go #

Patch Set 3 : diff -r 62e67a664a03 https://code.google.com/p/go #

Patch Set 4 : diff -r 62e67a664a03 https://code.google.com/p/go #

Patch Set 5 : diff -r 62e67a664a03 https://code.google.com/p/go #

Patch Set 6 : diff -r 62e67a664a03 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M misc/cgo/test/cgo_test.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue6438.go View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
M src/pkg/go/build/build.go View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2013-09-21 04:46:24 UTC) #1
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2013-09-21 04:55:27 UTC) #2
slimsag
On 2013/09/21 04:55:27, minux wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...
10 years, 6 months ago (2013-09-23 02:41:55 UTC) #3
rsc
was this broken in go1.1?
10 years, 6 months ago (2013-09-23 13:41:35 UTC) #4
minux1
On Mon, Sep 23, 2013 at 9:41 AM, <rsc@golang.org> wrote: > was this broken in ...
10 years, 6 months ago (2013-09-23 15:39:16 UTC) #5
rsc
10 years, 6 months ago (2013-09-23 20:04:29 UTC) #6
it did work once. but i broke it in CL http://codereview.appspot.com/5554079,
which happened a few months before Go 1. i will send a CL documenting the
new behavior.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b