code review 137870043: net: ensure identical queries are not sent multiple tim...

net: ensure identical queries are not sent multiple times in unix stub resolver

Prevents non-rooted queries with > ndots dots from being tried twice on error.
Fixes issue 8616.

Benchmark results on linux/amd64
benchmark                        old ns/op    new ns/op    delta
BenchmarkGoLookupIPNoSuchHost      8212394      4413293  -46.26%

benchmark                       old allocs   new allocs    delta
BenchmarkGoLookupIPNoSuchHost          216          108  -50.00%

benchmark                        old bytes    new bytes    delta
BenchmarkGoLookupIPNoSuchHost        17460         8726  -50.02%

[axaxs, 2014-08-29 22:07:18]

Hello golang-codereviews@googlegroups.com (cc: mikioh.mikioh@gmail.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2014-08-29 22:34:28]

LGTM

[mikio, 2014-08-29 22:43:31]

LGTM

[mikio, 2014-08-29 22:51:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=0ddf9c344a59 ***

net: ensure identical queries are not sent multiple times in builtin stub
resolver

Prevents non-rooted queries with > ndots dots from being tried twice on error.
Fixes issue 8616.

Benchmark results on linux/amd64
benchmark                        old ns/op    new ns/op    delta
BenchmarkGoLookupIPNoSuchHost      8212394      4413293  -46.26%

benchmark                       old allocs   new allocs    delta
BenchmarkGoLookupIPNoSuchHost          216          108  -50.00%

benchmark                        old bytes    new bytes    delta
BenchmarkGoLookupIPNoSuchHost        17460         8726  -50.02%

LGTM=iant, mikioh.mikioh
R=golang-codereviews, iant, mikioh.mikioh
CC=golang-codereviews
https://codereview.appspot.com/137870043

Committer: Mikio Hara <mikioh.mikioh@gmail.com>

[gobot, 2014-08-29 22:54:37]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/686c587a39bfdf95a5a959df5ba9651d22ba3d54