If you remember what the DWARF AttrLocation field format is, then some help with the ...
9 years, 6 months ago
(2014-09-10 07:37:29 UTC)
#2
If you remember what the DWARF AttrLocation field format is, then some help with
the new TODOs would be nice. Otherwise, I guess that I'll be reading the DWARF
spec tomorrow.
rsc, I'm maintaining a Go equivalent of runtime.topofstack. I see that you've made recent changes ...
9 years, 6 months ago
(2014-09-15 05:01:35 UTC)
#3
rsc, I'm maintaining a Go equivalent of runtime.topofstack. I see that
you've made recent changes on Go tip (to be 1.4), such as
https://codereview.appspot.com/137410043/ that removed
runtime.lessstack.
Are the stack changes pretty much done, or should I expect some more
runtime churn in the short trem (and therefore hold of on submitting
this CL for ogle)?
On Wed, Sep 10, 2014 at 5:36 PM, <nigeltao@golang.org> wrote:
> Reviewers: r,
>
> Message:
> Hello r@golang.org,
>
> I'd like you to review this change to
> https://code.google.com/p/ogle
>
>
> Description:
> ogle/program/server: update topOfStack to work with Go 1.4 binaries.
>
> Please review this at https://codereview.appspot.com/137460043/
>
> Affected files (+94, -40 lines):
> M program/server/dwarf.go
> M program/server/ptrace.go
> M program/server/server.go
*** Submitted as https://code.google.com/p/ogle/source/detail?r=55b3bcd8bbc8 *** ogle/program/server: update topOfStack to work with Go 1.4 binaries. TBR=r ...
9 years, 6 months ago
(2014-09-16 05:15:41 UTC)
#5
https://codereview.appspot.com/137460043/diff/130001/debug/dwarf/symbol.go File debug/dwarf/symbol.go (right): https://codereview.appspot.com/137460043/diff/130001/debug/dwarf/symbol.go#newcode62 debug/dwarf/symbol.go:62: // move around. Should this function be renamed LookupGlobal? ...
9 years, 6 months ago
(2014-09-19 03:51:19 UTC)
#6
Issue 137460043: code review 137460043: ogle/program/server: update topOfStack to work with Go ...
(Closed)
Created 9 years, 6 months ago by nigeltao
Modified 9 years, 6 months ago
Reviewers: r
Base URL:
Comments: 3