Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 137460043: code review 137460043: ogle/program/server: update topOfStack to work with Go ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by nigeltao
Modified:
9 years, 6 months ago
Reviewers:
r
CC:
rsc
Visibility:
Public.

Description

ogle/program/server: update topOfStack to work with Go 1.4 binaries.

Patch Set 1 #

Patch Set 2 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Patch Set 3 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Patch Set 4 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Patch Set 5 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Patch Set 6 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Patch Set 7 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Patch Set 8 : diff -r 72ea378d21c42241092681eb060872c3ddf80f6d https://code.google.com/p/ogle #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -111 lines) Patch
M debug/dwarf/frame.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M debug/dwarf/symbol.go View 1 2 3 4 5 4 chunks +66 lines, -44 lines 3 comments Download
M program/server/dwarf.go View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M program/server/ptrace.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M program/server/server.go View 1 2 3 4 5 6 7 5 chunks +66 lines, -64 lines 0 comments Download

Messages

Total messages: 6
nigeltao
Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle
9 years, 6 months ago (2014-09-10 07:36:25 UTC) #1
nigeltao
If you remember what the DWARF AttrLocation field format is, then some help with the ...
9 years, 6 months ago (2014-09-10 07:37:29 UTC) #2
nigeltao
rsc, I'm maintaining a Go equivalent of runtime.topofstack. I see that you've made recent changes ...
9 years, 6 months ago (2014-09-15 05:01:35 UTC) #3
rsc
i'm done with the stacks.
9 years, 6 months ago (2014-09-15 14:10:07 UTC) #4
nigeltao
*** Submitted as https://code.google.com/p/ogle/source/detail?r=55b3bcd8bbc8 *** ogle/program/server: update topOfStack to work with Go 1.4 binaries. TBR=r ...
9 years, 6 months ago (2014-09-16 05:15:41 UTC) #5
r
9 years, 6 months ago (2014-09-19 03:51:19 UTC) #6
Message was sent while issue was closed.
https://codereview.appspot.com/137460043/diff/130001/debug/dwarf/symbol.go
File debug/dwarf/symbol.go (right):

https://codereview.appspot.com/137460043/diff/130001/debug/dwarf/symbol.go#ne...
debug/dwarf/symbol.go:62: // move around. Should this function be renamed
LookupGlobal?
since the tag is TagVariable, i like the name it has now.

https://codereview.appspot.com/137460043/diff/130001/debug/dwarf/symbol.go#ne...
debug/dwarf/symbol.go:76: // TODO: is d.unit[0] always the right unit to take?
it's the only one we're using, so it better be.

https://codereview.appspot.com/137460043/diff/130001/debug/dwarf/symbol.go#ne...
debug/dwarf/symbol.go:77: if asize := d.unit[0].asize; loc[0] == opAddr ||
len(loc) == 1+asize {
shouldn't the || be &&?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b