Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(998)

Issue 13740047: code review 13740047: crypto/tls: document that the package supports TLS 1.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rsc
Modified:
10 years, 6 months ago
Reviewers:
minux1, sfrithjof, bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

crypto/tls: document that the package supports TLS 1.2 Fixes issue 6456.

Patch Set 1 #

Patch Set 2 : diff -r f31759c38a32 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f31759c38a32 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2c5ef107d15e https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/crypto/tls/common.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/tls.go View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 6 months ago (2013-09-23 19:58:23 UTC) #1
bradfitz
LGTM On Mon, Sep 23, 2013 at 12:58 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > ...
10 years, 6 months ago (2013-09-23 20:01:09 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=abdb7c7fdd0f *** crypto/tls: document that the package supports TLS 1.2 Fixes issue ...
10 years, 6 months ago (2013-09-23 20:05:27 UTC) #3
minux1
this didn't address point 3 of the issue?
10 years, 6 months ago (2013-09-23 20:06:15 UTC) #4
rsc
updated the issue, thanks.
10 years, 6 months ago (2013-09-23 20:12:32 UTC) #5
sfrithjof
10 years, 6 months ago (2013-09-24 10:09:58 UTC) #6
Message was sent while issue was closed.
https://codereview.appspot.com/13740047/diff/10001/src/pkg/crypto/tls/tls.go
File src/pkg/crypto/tls/tls.go (right):

https://codereview.appspot.com/13740047/diff/10001/src/pkg/crypto/tls/tls.go#...
src/pkg/crypto/tls/tls.go:5: // Package tls partially implements TLS 1.2, as
specified in RFC 4346.
This should now refer to RFC 5246 instead of 4346.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b