Issue 137380043: code review 137380043: strconv: fix documentation for CanBackquote.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 137380043: code review 137380043: strconv: fix documentation for CanBackquote. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by r

Modified:
9 years, 8 months ago

Reviewers:
gobot, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

strconv: fix documentation for CanBackquote. Space is not a control character. Fixes issue 8571.

Patch Set 2 : diff -r 862455e0916342f59979ccfdcedd35d5fca48cb1 https://code.google.com/p/go #

Patch Set 3 : diff -r e73f651486f0e6218794f1ee28ffa7258ebee75a https://code.google.com/p/go #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/strconv/quote.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 8 months ago (2014-09-08 21:22:29 UTC) #1

iant

https://codereview.appspot.com/137380043/diff/1/src/strconv/quote.go File src/strconv/quote.go (right): https://codereview.appspot.com/137380043/diff/1/src/strconv/quote.go#newcode146 src/strconv/quote.go:146: // characters other than space. s/space/tab/ ?

9 years, 8 months ago (2014-09-08 22:52:19 UTC) #2

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 8 months ago (2014-09-08 23:21:28 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=3baa31eaa172 *** strconv: fix documentation for CanBackquote. Space is not a control ...

9 years, 8 months ago (2014-09-09 18:45:39 UTC) #6

gobot

9 years, 8 months ago (2014-09-09 20:05:09 UTC) #7

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/f6d11ef89b09b0821799025a303b90c666226460

Expand All Messages | Collapse All Messages