Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(532)

Issue 13704044: code review 13704044: cmd/dist, cmd/go: embed default C++ compiler into cmd/go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by minux1
Modified:
10 years, 6 months ago
Reviewers:
rsc
CC:
golang-dev, dfc, rsc
Visibility:
Public.

Description

cmd/dist, cmd/go: embed default C++ compiler into cmd/go Fixes issue 6426.

Patch Set 1 #

Patch Set 2 : diff -r d5f023ae1d0e https://code.google.com/p/go #

Patch Set 3 : diff -r d5f023ae1d0e https://code.google.com/p/go #

Patch Set 4 : diff -r 7464c57d4ccd https://code.google.com/p/go #

Patch Set 5 : diff -r 7464c57d4ccd https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M src/cmd/dist/a.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/dist/build.c View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/cmd/dist/buildgo.c View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/cmd/go/build.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/go/env.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2013-09-21 00:55:52 UTC) #1
dfc
Change looks good by I find the issue description confusing. Would "cmd/dist, cmd/go: pass CXX ...
10 years, 6 months ago (2013-09-21 00:57:52 UTC) #2
minux1
On Fri, Sep 20, 2013 at 8:57 PM, Dave Cheney <dave@cheney.net> wrote: > Change looks ...
10 years, 6 months ago (2013-09-22 02:15:37 UTC) #3
rsc
LGTM
10 years, 6 months ago (2013-09-23 19:41:46 UTC) #4
minux1
10 years, 6 months ago (2013-09-24 04:17:14 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=1607e9e9e6de ***

cmd/dist, cmd/go: embed default C++ compiler into cmd/go
Fixes issue 6426.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/13704044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b