Issue 13704043: code review 13704043: go.crypto/ssh/terminal: support Unicode entry.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13704043: code review 13704043: go.crypto/ssh/terminal: support Unicode entry. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by agl1

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

go.crypto/ssh/terminal: support Unicode entry. Previously, terminal only supported ASCII characters. This change alters some []byte to []rune so that the full range of Unicode is supported. The only thing that doesn't appear to work correctly are grapheme clusters as the code still assumes one rune per glyph. Still, this change allows many more languages to work than did previously.

Patch Set 1 #

Patch Set 2 : diff -r 4119545f658f https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 84f83fa76088 https://code.google.com/p/go.crypto/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -36 lines)			Patch
	M	ssh/terminal/terminal.go	View	1	17 chunks	+46 lines, -36 lines	0 comments	Download
	M	ssh/terminal/terminal_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

10 years, 7 months ago (2013-09-13 18:32:58 UTC) #3

agl1

10 years, 7 months ago (2013-09-13 18:33:08 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=ff9ce887b46b&repo=crypto ***

go.crypto/ssh/terminal: support Unicode entry.

Previously, terminal only supported ASCII characters. This change
alters some []byte to []rune so that the full range of Unicode is
supported. The only thing that doesn't appear to work correctly are
grapheme clusters as the code still assumes one rune per glyph. Still,
this change allows many more languages to work than did previously.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13704043

Expand All Messages | Collapse All Messages