Issue 137010043: code review 137010043: undo CL 135230043 / 60812bad3769

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 137010043: code review 137010043: undo CL 135230043 / 60812bad3769 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
gobot, iant, mdempsky

CC:
golang-codereviews

Visibility:
Public.

Description

undo CL 135230043 / 60812bad3769 broke api check everywhere ««« original CL description runtime: fix openbsd build LGTM=iant R=iant, minux CC=golang-codereviews, jsing https://codereview.appspot.com/135230043 Committer: Ian Lance Taylor <iant@golang.org> »»»

Patch Set 1 #

Patch Set 2 : diff -r a32faf936e4582e45ed1f3e147e41548aaf7ad96 https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
M	src/pkg/runtime/defs_openbsd.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/defs_openbsd_386.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/defs_openbsd_amd64.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/os_openbsd.c	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/os_openbsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello mdempsky@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 6 months ago (2014-08-30 04:16:01 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=1041a5493f10 *** undo CL 135230043 / 60812bad3769 broke api check everywhere ««« ...

10 years, 6 months ago (2014-08-30 04:16:07 UTC) #2

gobot

This CL appears to have broken the windows-amd64-perf builder. See http://build.golang.org/log/4dcfbc49fc8c1c65afb7d3a51b4ec7a3cbd91f11

10 years, 6 months ago (2014-08-30 04:17:02 UTC) #3

iant

LGTM Sorry about that, I didn't think I needed to build it since it only ...

10 years, 6 months ago (2014-08-30 04:17:42 UTC) #4

mdempsky

10 years, 6 months ago (2014-08-30 04:20:00 UTC) #5

Message was sent while issue was closed.

On 2014/08/30 04:17:42, iant wrote:
> LGTM
> 
> Sorry about that, I didn't think I needed to build it since it only touched
> openbsd files....

Same here. :-/

Reverting just os_openbsd.go would have worked too (e.g.,
https://codereview.appspot.com/134140043/ which I was about to mail out), but
I'll send the original CL again without that change.

Thanks for rolling it back.

Expand All Messages | Collapse All Messages