Issue 136870043: code review 136870043: runtime: restore header to first goroutine in Stack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 136870043: code review 136870043: runtime: restore header to first goroutine in Stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by bradfitz

Modified:
10 years, 6 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, josharian, khr, remyoudompheng, rsc

Visibility:
Public.

Description

runtime: restore header to first goroutine in Stack It appears to have been accidentally lost when converting Stack from C to Go in https://codereview.appspot.com/129510043

Patch Set 1 #

Patch Set 2 : diff -r 05c3fee13eb3052c646ccfd389e3629e5cb12b7f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 05c3fee13eb3052c646ccfd389e3629e5cb12b7f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 05c3fee13eb3052c646ccfd389e3629e5cb12b7f https://go.googlecode.com/hg/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/pkg/runtime/mprof.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/runtime/stubs.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-codereviews@googlegroups.com (cc: josharian@gmail.com, khr@golang.org, remyoudompheng@gmail.com, rsc@golang.org), I'd like you to review this change to ...

10 years, 6 months ago (2014-08-27 16:16:14 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=e2d8b8168b12 *** runtime: restore header to first goroutine in Stack It appears ...

10 years, 6 months ago (2014-08-27 16:31:35 UTC) #3

gobot

10 years, 6 months ago (2014-08-27 16:33:50 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/039850297a559f0c333eb6ffe7d0dbbbb202a122

Expand All Messages | Collapse All Messages