Issue 136700043: code review 136700043: net: make TestSelfConnect less fragile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 136700043: code review 136700043: net: make TestSelfConnect less fragile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by rsc

Modified:
9 years, 7 months ago

Reviewers:
bradfitz

CC:
bradfitz, golang-codereviews, rlh

Visibility:
Public.

Description

net: make TestSelfConnect less fragile We believe TestSelfConnect can accidentally connect to something else listening on or dialing from that port. Fixes issue 8680.

Patch Set 1 #

Patch Set 2 : diff -r 86735ca806e08b2ee073776fdddd0f7712dd788a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 86735ca806e08b2ee073776fdddd0f7712dd788a https://code.google.com/p/go/ #

Patch Set 4 : diff -r e423b2f2d361065a26557d4375f4716f668b3fac https://code.google.com/p/go/ #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/net/dial_test.go	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello bradfitz (cc: golang-codereviews@googlegroups.com, rlh), I'd like you to review this change to https://code.google.com/p/go/

9 years, 7 months ago (2014-09-16 15:11:07 UTC) #1

rsc

I didn't meant to send out the unconditional Skipf. Let's try with just the extra ...

9 years, 7 months ago (2014-09-16 17:45:06 UTC) #3

bradfitz

It was conditional on testing.Short(), which seems fine. Either way. On Tue, Sep 16, 2014 ...

9 years, 7 months ago (2014-09-16 17:52:13 UTC) #4

rsc

9 years, 7 months ago (2014-09-16 18:03:03 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=ab3588ba2386 ***

net: make TestSelfConnect less fragile

We believe TestSelfConnect can accidentally connect to
something else listening on or dialing from that port.

Fixes issue 8680.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews, rlh
https://codereview.appspot.com/136700043

Expand All Messages | Collapse All Messages