Issue 13662043: code review 13662043: runtime: show m stack during crash on m stack

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13662043: code review 13662043: runtime: show m stack during crash on m stack (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

runtime: show m stack during crash on m stack The various throwing > 0 finish a change started in a previous CL, which sets throwing = -1 to mean "don't show the internals". That gets set during the "all goroutines are asleep - deadlock!" crash, and it should also be set during any other expected crash that does not indicate a problem within the runtime. Most runtime.throw do indicate a problem within the runtime, however, so we should be able to enumerate the ones that should be silent. The goroutine sleeping deadlock is the only one I can think of. Update issue 5139

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	src/pkg/runtime/panic.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/traceback_arm.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/traceback_x86.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 8 months ago (2013-09-11 15:49:46 UTC) #1

rsc

10 years, 8 months ago (2013-09-11 16:00:40 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ef73acc06701 ***

runtime: show m stack during crash on m stack

The various throwing > 0 finish a change started
in a previous CL, which sets throwing = -1 to mean
"don't show the internals". That gets set during the
"all goroutines are asleep - deadlock!" crash, and it
should also be set during any other expected crash
that does not indicate a problem within the runtime.

Most runtime.throw do indicate a problem within the
runtime, however, so we should be able to enumerate
the ones that should be silent. The goroutine sleeping
deadlock is the only one I can think of.

Update issue 5139

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13662043

Expand All Messages | Collapse All Messages