Issue 13661043: code review 13661043: go/build: reject directory with only cgo files if cgo n...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13661043: code review 13661043: go/build: reject directory with only cgo files if cgo n... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

go/build: reject directory with only cgo files if cgo not in use The old test for "no Go files" was p.Name == "", meaning we never saw a Go package statement. That test fails if there are cgo files that we parsed (and recorded the package name) but then chose not to use (because cgo is not available). Test the actual file lists instead. Fixes issue 6078.

Patch Set 1 #

Patch Set 2 : diff -r 1b195d6fe342 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 46fd4ef6c0de https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r ef73acc06701 https://code.google.com/p/go/ #

Patch Set 5 : diff -r a74e4a7820d0 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
M	src/cmd/go/test.bash	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/cgotest/m.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/go/build/build.go	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-11 15:30:24 UTC) #1

iant

https://codereview.appspot.com/13661043/diff/5001/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/13661043/diff/5001/src/cmd/go/test.bash#newcode173 src/cmd/go/test.bash:173: if ./testgo install cgotest 2>testdata/err; then Where is cgotest ...

11 years, 6 months ago (2013-09-11 15:45:37 UTC) #2

rsc

11 years, 6 months ago (2013-09-11 17:25:34 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=63f29041c1cf ***

go/build: reject directory with only cgo files if cgo not in use

The old test for "no Go files" was p.Name == "", meaning we never
saw a Go package statement. That test fails if there are cgo files
that we parsed (and recorded the package name) but then chose
not to use (because cgo is not available).

Test the actual file lists instead.

Fixes issue 6078.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13661043

Expand All Messages | Collapse All Messages