code review 13660043: syscall: add TCIOFLUSH family of constants

syscall: add TCIOFLUSH family of constants

Fixes issue 6355.

zerrors_linux_{386,amd64,arm}.go were regenerated using mkerrors.sh but I opted to add the three TC.*FLUSH lines by hand to keep the diff smaller and avoid problems with the API checker.

I'll check freebsd and darwin, could I ask for help with net/open bsd.

[dave_cheney.net, 2013-09-11 09:24:03]

Hello mikioh.mikioh@gmail.com, jsing@google.com, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-09-11 09:25:38]

LGTM



On Wed, Sep 11, 2013 at 2:24 AM, <dave@cheney.net> wrote:

> Reviewers: mikio, jsing, minux,
>
> Message:
> Hello mikioh.mikioh@gmail.com, jsing@google.com, minux.ma@gmail.com (cc:
> golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> syscall: add TCIOFLUSH family of constants
>
> Fixes issue 6355.
>
> zerrors_linux_{386,amd64,arm}.**go were regenerated using mkerrors.sh but
> I opted to add the three TC.*FLUSH lines by hand to keep the diff
> smaller and avoid provlems with the API checker.
>
> I'll check freebsd and darwin, could I ask for help with net/open bsd.
>
> Please review this at
https://codereview.appspot.**com/13660043/<https://codereview.appspot.com/136...
>
> Affected files (+19, -0 lines):
>   M src/pkg/syscall/consistency_**unix_test.go
>   M src/pkg/syscall/mkerrors.sh
>   M src/pkg/syscall/zerrors_linux_**386.go
>   M src/pkg/syscall/zerrors_linux_**amd64.go
>   M src/pkg/syscall/zerrors_linux_**arm.go
>
>
> Index: src/pkg/syscall/consistency_**unix_test.go
> ==============================**==============================**=======
> --- a/src/pkg/syscall/consistency_**unix_test.go
> +++ b/src/pkg/syscall/consistency_**unix_test.go
> @@ -23,3 +23,12 @@
>                 _ int = syscall.PRIO_PGRP
>         )
>  }
> +
> +// termios functions and constants
> +func _() {
> +       const (
> +               _ int = syscall.TCIFLUSH
> +               _ int = syscall.TCIOFLUSH
> +               _ int = syscall.TCOFLUSH
> +       )
> +}
> Index: src/pkg/syscall/mkerrors.sh
> ==============================**==============================**=======
> --- a/src/pkg/syscall/mkerrors.sh
> +++ b/src/pkg/syscall/mkerrors.sh
> @@ -107,6 +107,7 @@
>  #include <net/if_arp.h>
>  #include <net/route.h>
>  #include <netpacket/packet.h>
> +#include <termios.h>
>
>  #ifndef MSG_FASTOPEN
>  #define MSG_FASTOPEN    0x20000000
> Index: src/pkg/syscall/zerrors_linux_**386.go
> ==============================**==============================**=======
> --- a/src/pkg/syscall/zerrors_**linux_386.go
> +++ b/src/pkg/syscall/zerrors_**linux_386.go
> @@ -1084,6 +1084,9 @@
>         S_IXGRP                          = 0x8
>         S_IXOTH                          = 0x1
>         S_IXUSR                          = 0x40
> +       TCIFLUSH                         = 0x0
> +       TCIOFLUSH                        = 0x2
> +       TCOFLUSH                         = 0x1
>         TCP_CONGESTION                   = 0xd
>         TCP_CORK                         = 0x3
>         TCP_DEFER_ACCEPT                 = 0x9
> Index: src/pkg/syscall/zerrors_linux_**amd64.go
> ==============================**==============================**=======
> --- a/src/pkg/syscall/zerrors_**linux_amd64.go
> +++ b/src/pkg/syscall/zerrors_**linux_amd64.go
> @@ -1085,6 +1085,9 @@
>         S_IXGRP                          = 0x8
>         S_IXOTH                          = 0x1
>         S_IXUSR                          = 0x40
> +       TCIFLUSH                         = 0x0
> +       TCIOFLUSH                        = 0x2
> +       TCOFLUSH                         = 0x1
>         TCP_CONGESTION                   = 0xd
>         TCP_CORK                         = 0x3
>         TCP_DEFER_ACCEPT                 = 0x9
> Index: src/pkg/syscall/zerrors_linux_**arm.go
> ==============================**==============================**=======
> --- a/src/pkg/syscall/zerrors_**linux_arm.go
> +++ b/src/pkg/syscall/zerrors_**linux_arm.go
> @@ -1095,6 +1095,9 @@
>         S_IXGRP                          = 0x8
>         S_IXOTH                          = 0x1
>         S_IXUSR                          = 0x40
> +       TCIFLUSH                         = 0x0
> +       TCIOFLUSH                        = 0x2
> +       TCOFLUSH                         = 0x1
>         TCP_CONGESTION                   = 0xd
>         TCP_CORK                         = 0x3
>         TCP_DEFER_ACCEPT                 = 0x9
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[dave_cheney.net, 2013-09-11 12:59:55]

This passes on all the systems I have access to. I'll submit this tomorrow.

[mikio, 2013-09-12 03:07:36]

LGTM

sigh, clang breaks syscall bootstrap stuff on darwin.

[minux1, 2013-09-12 03:10:43]

I've checked NetBSD/{386,amd64,arm}.

LGTM.

[dave_cheney.net, 2013-09-13 05:01:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=0f036b4b1da5 ***

syscall: add TCIOFLUSH family of constants

Fixes issue 6355.

zerrors_linux_{386,amd64,arm}.go were regenerated using mkerrors.sh but I opted
to add the three TC.*FLUSH lines by hand to keep the diff smaller and avoid
problems with the API checker.

I'll check freebsd and darwin, could I ask for help with net/open bsd.

R=mikioh.mikioh, jsing, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/13660043