Issue 13638043: code review 13638043: go-tour/gotour: fix bug in argument handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13638043: code review 13638043: go-tour/gotour: fix bug in argument handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by r

Modified:
10 years, 8 months ago

Reviewers:
adg

CC:
adg, golang-dev

Visibility:
Public.

Description

go-tour/gotour: fix bug in argument handling Don't use the default after going to all that trouble to override it. Mea culpa.

Patch Set 1 #

Patch Set 2 : diff -r 701b21164db6 https://code.google.com/p/go-tour #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gotour/tour.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 8 months ago (2013-09-10 04:42:14 UTC) #1

10 years, 8 months ago (2013-09-11 02:02:54 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=c1b6d0fd7ca4
***

go-tour/gotour: fix bug in argument handling
Don't use the default after going to all that trouble to override it.
Mea culpa.

R=adg
CC=golang-dev
https://codereview.appspot.com/13638043

Expand All Messages | Collapse All Messages