code review 136090043: go.tools/go/types: add (*PkgName).ImportedPackage method.

go.tools/go/types: add (*PkgName).ImportedPackage method.

It returns the value formerly returned by Pkg(), i.e. the imported package.
Pkg() now returns the package enclosing the import statement,
which is consistent with all other Objects.

Fixes issue 8628.

[adonovan, 2014-09-02 19:31:05]

Hello gri@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[gri, 2014-09-02 20:19:30]

https://codereview.appspot.com/136090043/diff/40001/go/types/object.go
File go/types/object.go (right):

https://codereview.appspot.com/136090043/diff/40001/go/types/object.go#newcod...
go/types/object.go:126: func (obj *PkgName) ImportedPackage() *Package { return
obj.imported }
s/ImportedPackage/Imported/

seems good enough and matches typical accessor naming pattern

https://codereview.appspot.com/136090043/diff/40001/go/types/resolver.go
File go/types/resolver.go (right):

https://codereview.appspot.com/136090043/diff/40001/go/types/resolver.go#newc...
go/types/resolver.go:400: check.softErrorf(obj.pos, "%q imported but not used",
obj.ImportedPackage().path)
obj.imported

[adonovan, 2014-09-02 20:32:23]

Hello gri@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[gri, 2014-09-02 22:03:25]

LGTM

did you check the go/importer tests

https://codereview.appspot.com/136090043/diff/2/go/types/object.go
File go/types/object.go (right):

https://codereview.appspot.com/136090043/diff/2/go/types/object.go#newcode125
go/types/object.go:125: // It is never equal to Pkg(), which is the package
containing the import statement.
one can probably construct cycles...

https://codereview.appspot.com/136090043/diff/2/go/types/object.go#newcode235
go/types/object.go:235: if path := obj.Imported().path; path != "" && path !=
obj.Name() {
obj.imported.path I think should be ok

and obj.name ?

[adonovan, 2014-09-02 22:11:53]

I ran the go/importer tests.

https://codereview.appspot.com/136090043/diff/2/go/types/object.go
File go/types/object.go (right):

https://codereview.appspot.com/136090043/diff/2/go/types/object.go#newcode125
go/types/object.go:125: // It is never equal to Pkg(), which is the package
containing the import statement.
On 2014/09/02 22:03:25, gri wrote:
> one can probably construct cycles...

Good point.  Reworded.

https://codereview.appspot.com/136090043/diff/2/go/types/object.go#newcode235
go/types/object.go:235: if path := obj.Imported().path; path != "" && path !=
obj.Name() {
On 2014/09/02 22:03:25, gri wrote:
> obj.imported.path I think should be ok
> 
> and obj.name ?

Done.  I'd be surprised if the object code wasn't identical though.

[adonovan, 2014-09-02 22:12:10]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b0670ff99296&repo=tools ***

go.tools/go/types: add (*PkgName).ImportedPackage method.

It returns the value formerly returned by Pkg(), i.e. the imported package.
Pkg() now returns the package enclosing the import statement,
which is consistent with all other Objects.

Fixes issue 8628.

LGTM=gri
R=gri
CC=golang-codereviews
https://codereview.appspot.com/136090043