Issue 13602045: code review 13602045: cmd/5g, cmd/6g, cmd/8g: remove O(n) reset loop in copyprop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13602045: code review 13602045: cmd/5g, cmd/6g, cmd/8g: remove O(n) reset loop in copyprop (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
dave, dvyukov

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/5g, cmd/6g, cmd/8g: remove O(n) reset loop in copyprop Simpler version of CL 13084043.

Patch Set 1 #

Patch Set 2 : diff -r bdd1742fed7d https://code.google.com/p/go/ #

Patch Set 3 : diff -r bdd1742fed7d https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
M	src/cmd/5g/peep.c	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	src/cmd/6g/peep.c	View	1	5 chunks	+7 lines, -5 lines	0 comments	Download
M	src/cmd/8g/peep.c	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-11 19:22:09 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=c47375e68297 *** cmd/5g, cmd/6g, cmd/8g: remove O(n) reset loop in copyprop Simpler ...

11 years, 6 months ago (2013-09-11 19:22:15 UTC) #2

dave_cheney.net

11 years, 6 months ago (2013-09-12 01:08:00 UTC) #4

Message was sent while issue was closed.

On 2013/09/11 20:38:25, dvyukov wrote:
> LGTM

Nice. 

before: (after rsc rolled back the previous version, just before this CL was
committed)
lucky(~/go/src) % time go install -a std

real    0m7.010s
user    0m12.416s
sys     0m2.896s

after:
lucky(~/go/src) % time go install -a std

real    0m6.252s
user    0m10.624s
sys     0m2.804s

Expand All Messages | Collapse All Messages