Issue 13593043: code review 13593043: go.tools/cmd/oracle: use -pos=file:#start,#end syntax t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13593043: code review 13593043: go.tools/cmd/oracle: use -pos=file:#start,#end syntax t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by adonovan

Modified:
10 years, 8 months ago

Reviewers:
r, crawshaw1, rsc

CC:
r, crawshaw1, rsc, golang-dev

Visibility:
Public.

Description

go.tools/cmd/oracle: use -pos=file:#start,#end syntax to indicate half-open [start,end) extent of byte offsets. Also: improve help message.

Patch Set 1 #

Patch Set 2 : diff -r e7de9f20df13 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r e7de9f20df13 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 1f863f06c64d https://code.google.com/p/go.tools #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
M	cmd/oracle/main.go	View	1 2 3	5 chunks	+16 lines, -9 lines	0 comments	Download
M	cmd/oracle/oracle.el	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/oracle/oracle.vim	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	oracle/oracle.go	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	oracle/oracle_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

adonovan

Hello r@golang.org, crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 8 months ago (2013-09-06 18:49:53 UTC) #1

adonovan

On 2013/09/06 19:18:14, crawshaw1 wrote: > What's the motivation? During a chat with Rob he ...

10 years, 8 months ago (2013-09-06 19:21:55 UTC) #3

adonovan

10 years, 8 months ago (2013-09-09 02:10:13 UTC) #7

*** Submitted as
https://code.google.com/p/go/source/detail?r=aa9b649bccd9&repo=tools ***

go.tools/cmd/oracle: use -pos=file:#start,#end syntax to indicate half-open
[start,end) extent of byte offsets.

Also: improve help message.

R=r, crawshaw, rsc
CC=golang-dev
https://codereview.appspot.com/13593043

Expand All Messages | Collapse All Messages