code review 135930043: runtime: convert print.c to Go

runtime: convert print.c to Go

[rsc, 2014-08-28 16:35:32]

Hello golang-codereviews@googlegroups.com (cc: dvyukov, iant, khr, r),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-08-28 16:53:45]

LGTM

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go
File src/pkg/runtime/print1.go (right):

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go...
src/pkg/runtime/print1.go:24: // Right now a dynamically allocated string that
is being passed as an
Is there an issue open for this?

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go...
src/pkg/runtime/print1.go:49: //g.writebuf =
(*[1<<30]byte)(unsafe.Pointer(dst))[:n]
Remove comment?

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go...
src/pkg/runtime/print1.go:76: writebuf = writebuf[n:]
This line serves no obvious purpose.

[rsc, 2014-08-29 03:25:32]

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go
File src/pkg/runtime/print1.go (right):

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go...
src/pkg/runtime/print1.go:24: // Right now a dynamically allocated string that
is being passed as an
On 2014/08/28 16:53:44, iant wrote:
> Is there an issue open for this?

done. 8614

https://codereview.appspot.com/135930043/diff/60001/src/pkg/runtime/print1.go...
src/pkg/runtime/print1.go:49: //g.writebuf =
(*[1<<30]byte)(unsafe.Pointer(dst))[:n]
On 2014/08/28 16:53:44, iant wrote:
> Remove comment?

the comments were trying to leave notes about how to make writebuf a slice.
i will just do it instead.

[rsc, 2014-08-29 03:26:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=2dae02db5c70 ***

runtime: convert print.c to Go

LGTM=iant
R=golang-codereviews, iant
CC=dvyukov, golang-codereviews, khr, r
https://codereview.appspot.com/135930043

[gobot, 2014-08-29 03:32:53]

This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/38cd13cf43b783c68c451649539c5903cf94603a

[khr1, 2014-08-29 05:21:02]

CL 139890043 should fix this.


On Thu, Aug 28, 2014 at 8:32 PM, <gobot@golang.org> wrote:

> This CL appears to have broken the netbsd-386-minux builder.
> See http://build.golang.org/log/38cd13cf43b783c68c451649539c5903cf94603a
>
> https://codereview.appspot.com/135930043/
>

[0intro, 2014-08-29 06:19:00]

We have this failure on Plan 9:

panic: runtime error: index out of range

goroutine 1 [running]:
runtime.panic(0x1bf640, 0x10574080)
	/usr/go/src/pkg/runtime/panic.c:278 +0xe3 fp=0x104a5d58 sp=0x104a5d08
runtime.panicindex()
	/usr/go/src/pkg/runtime/panic.go:8 +0x56 fp=0x104a5d74 sp=0x104a5d58
runtime.snprintf(0x104a5dc0, 0x80, 0x2f8626)
	/usr/go/src/pkg/runtime/print1.go:54 +0xf2 fp=0x104a5da8 sp=0x104a5d74
runtime.goexitsall(0x2f863f)
	/usr/go/src/pkg/runtime/os_plan9.c:214 +0x51 fp=0x104a5e44 sp=0x104a5da8
runtime.exit(0x0)
	/usr/go/src/pkg/runtime/os_plan9.c:268 +0x3d fp=0x104a5e68 sp=0x104a5e44
syscall.exit(0x0)
	/usr/go/src/pkg/syscall/asm_plan9_386.s:163 +0xf fp=0x104a5e70 sp=0x104a5e68
syscall.Exit(0x0)
	/usr/go/src/pkg/syscall/syscall_plan9.go:88 +0x2d fp=0x104a5e78 sp=0x104a5e70
os.Exit(0x0)
	/usr/go/src/pkg/os/proc.go:36 +0x2d fp=0x104a5e80 sp=0x104a5e78
main.exit()
	/usr/go/src/cmd/go/main.go:348 +0x7c fp=0x104a5ea0 sp=0x104a5e80
main.main()
	/usr/go/src/cmd/go/main.go:164 +0x449 fp=0x104a5f98 sp=0x104a5ea0
runtime.main()
	/usr/go/src/pkg/runtime/proc.c:266 +0x134 fp=0x104a5fd0 sp=0x104a5f98
runtime.goexit()
	/usr/go/src/pkg/runtime/proc.c:1633 fp=0x104a5fd4 sp=0x104a5fd0

goroutine 2 [force gc (idle)]:
runtime.park(0x6d2b0, 0x2fb9f0, 0x2fb04a, 0xf)
	/usr/go/src/pkg/runtime/proc.c:1559 +0x7a fp=0x1044bfa4 sp=0x1044bf9c
runtime.parkunlock(0x2fb9f0, 0x2fb04a, 0xf)
	/usr/go/src/pkg/runtime/proc.c:1575 +0x46 fp=0x1044bfb8 sp=0x1044bfa4
forcegchelper()
	/usr/go/src/pkg/runtime/proc.c:2955 +0xa1 fp=0x1044bfd0 sp=0x1044bfb8
runtime.goexit()
	/usr/go/src/pkg/runtime/proc.c:1633 fp=0x1044bfd4 sp=0x1044bfd0
created by runtime.main
	/usr/go/src/pkg/runtime/proc.c:225

goroutine 3 [runnable]:
runtime.gosched()
	/usr/go/src/pkg/runtime/proc.c:1604 +0x2b fp=0x10447fb8 sp=0x10447fb0
bgsweep()
	/usr/go/src/pkg/runtime/mgc0.c:1061 +0x46 fp=0x10447fd0 sp=0x10447fb8
runtime.goexit()
	/usr/go/src/pkg/runtime/proc.c:1633 fp=0x10447fd4 sp=0x10447fd0
created by runtime.gc
	/usr/go/src/pkg/runtime/mgc0.c:1290

goroutine 4 [finalizer wait]:
runtime.gopark(0x6d2b0, 0x2fb490, 0x1f6cc8, 0xe)
	/usr/go/src/pkg/runtime/proc.go:58 +0x95 fp=0x10431f84 sp=0x10431f70
runtime.goparkunlock(0x2fb490, 0x1f6cc8, 0xe)
	/usr/go/src/pkg/runtime/proc.go:63 +0x47 fp=0x10431f98 sp=0x10431f84
runtime.runfinq()
	/usr/go/src/pkg/runtime/malloc.go:721 +0x8e fp=0x10431fd0 sp=0x10431f98
runtime.goexit()
	/usr/go/src/pkg/runtime/proc.c:1633 fp=0x10431fd4 sp=0x10431fd0
created by runtime.createfing
	/usr/go/src/pkg/runtime/malloc.go:701 +0x5b

[dave_cheney.net, 2014-08-29 06:20:32]

What is runtime.goexitsall trying to print ?

On Fri, Aug 29, 2014 at 4:19 PM,  <0intro@gmail.com> wrote:
> We have this failure on Plan 9:
>
> panic: runtime error: index out of range
>
> goroutine 1 [running]:
> runtime.panic(0x1bf640, 0x10574080)
>         /usr/go/src/pkg/runtime/panic.c:278 +0xe3 fp=0x104a5d58
> sp=0x104a5d08
> runtime.panicindex()
>         /usr/go/src/pkg/runtime/panic.go:8 +0x56 fp=0x104a5d74 sp=0x104a5d58
> runtime.snprintf(0x104a5dc0, 0x80, 0x2f8626)
>         /usr/go/src/pkg/runtime/print1.go:54 +0xf2 fp=0x104a5da8
> sp=0x104a5d74
> runtime.goexitsall(0x2f863f)
>         /usr/go/src/pkg/runtime/os_plan9.c:214 +0x51 fp=0x104a5e44
> sp=0x104a5da8
> runtime.exit(0x0)
>         /usr/go/src/pkg/runtime/os_plan9.c:268 +0x3d fp=0x104a5e68
> sp=0x104a5e44
> syscall.exit(0x0)
>         /usr/go/src/pkg/syscall/asm_plan9_386.s:163 +0xf fp=0x104a5e70
> sp=0x104a5e68
> syscall.Exit(0x0)
>         /usr/go/src/pkg/syscall/syscall_plan9.go:88 +0x2d fp=0x104a5e78
> sp=0x104a5e70
> os.Exit(0x0)
>         /usr/go/src/pkg/os/proc.go:36 +0x2d fp=0x104a5e80 sp=0x104a5e78
> main.exit()
>         /usr/go/src/cmd/go/main.go:348 +0x7c fp=0x104a5ea0 sp=0x104a5e80
> main.main()
>         /usr/go/src/cmd/go/main.go:164 +0x449 fp=0x104a5f98 sp=0x104a5ea0
> runtime.main()
>         /usr/go/src/pkg/runtime/proc.c:266 +0x134 fp=0x104a5fd0
> sp=0x104a5f98
> runtime.goexit()
>         /usr/go/src/pkg/runtime/proc.c:1633 fp=0x104a5fd4 sp=0x104a5fd0
>
> goroutine 2 [force gc (idle)]:
> runtime.park(0x6d2b0, 0x2fb9f0, 0x2fb04a, 0xf)
>         /usr/go/src/pkg/runtime/proc.c:1559 +0x7a fp=0x1044bfa4
> sp=0x1044bf9c
> runtime.parkunlock(0x2fb9f0, 0x2fb04a, 0xf)
>         /usr/go/src/pkg/runtime/proc.c:1575 +0x46 fp=0x1044bfb8
> sp=0x1044bfa4
> forcegchelper()
>         /usr/go/src/pkg/runtime/proc.c:2955 +0xa1 fp=0x1044bfd0
> sp=0x1044bfb8
> runtime.goexit()
>         /usr/go/src/pkg/runtime/proc.c:1633 fp=0x1044bfd4 sp=0x1044bfd0
> created by runtime.main
>         /usr/go/src/pkg/runtime/proc.c:225
>
> goroutine 3 [runnable]:
> runtime.gosched()
>         /usr/go/src/pkg/runtime/proc.c:1604 +0x2b fp=0x10447fb8
> sp=0x10447fb0
> bgsweep()
>         /usr/go/src/pkg/runtime/mgc0.c:1061 +0x46 fp=0x10447fd0
> sp=0x10447fb8
> runtime.goexit()
>         /usr/go/src/pkg/runtime/proc.c:1633 fp=0x10447fd4 sp=0x10447fd0
> created by runtime.gc
>         /usr/go/src/pkg/runtime/mgc0.c:1290
>
> goroutine 4 [finalizer wait]:
> runtime.gopark(0x6d2b0, 0x2fb490, 0x1f6cc8, 0xe)
>         /usr/go/src/pkg/runtime/proc.go:58 +0x95 fp=0x10431f84 sp=0x10431f70
> runtime.goparkunlock(0x2fb490, 0x1f6cc8, 0xe)
>         /usr/go/src/pkg/runtime/proc.go:63 +0x47 fp=0x10431f98 sp=0x10431f84
> runtime.runfinq()
>         /usr/go/src/pkg/runtime/malloc.go:721 +0x8e fp=0x10431fd0
> sp=0x10431f98
> runtime.goexit()
>         /usr/go/src/pkg/runtime/proc.c:1633 fp=0x10431fd4 sp=0x10431fd0
> created by runtime.createfing
>         /usr/go/src/pkg/runtime/malloc.go:701 +0x5b
>
>
>
> https://codereview.appspot.com/135930043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[0intro, 2014-08-29 06:54:28]

> What is runtime.goexitsall trying to print ?

The status variable points to an empty string here.
Runtime·goexitsall is trying to print "go: exit ".

[mpl, 2014-09-01 21:40:42]

On 2014/08/29 03:26:44, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=2dae02db5c70 ***
> 
> runtime: convert print.c to Go
> 
> LGTM=iant
> R=golang-codereviews, iant
> CC=dvyukov, golang-codereviews, khr, r
> https://codereview.appspot.com/135930043

A Camlistore's buildbot test relying on runtime.Stack failed after this change.
Something like that http://play.golang.org/p/NOrrAhBF2x does not work anymore.