Issue 135900043: code review 135900043: runtime: fix plan9 build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 135900043: code review 135900043: runtime: fix plan9 build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
gobot, 0intro

CC:
golang-codereviews

Visibility:
Public.

runtime: fix plan9 build sighandler now returns its value on the stack.

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	src/pkg/runtime/sys_plan9_386.s	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	src/pkg/runtime/sys_plan9_amd64.s	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 4

rsc

Hello 0intro (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 6 months ago (2014-08-27 21:37:59 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=182648735343 *** runtime: fix plan9 build sighandler now returns its value on ...

10 years, 6 months ago (2014-08-27 21:38:05 UTC) #2

gobot

This CL appears to have broken the freebsd-amd64-race builder. See http://build.golang.org/log/058da1d8fe18703f03d4640ac2a8fad26b10c181

10 years, 6 months ago (2014-08-27 21:57:00 UTC) #3

Message was sent while issue was closed.

LGTM

Thanks.