code review 13586043: sort: add a simpler sort.Interface example

sort: add a simpler sort.Interface example

Existing example renamed to Example_sortWrapper.
Fixes issue 6335.

[cronos, 2013-09-06 08:51:17]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-09-06 20:33:43]

LGTM

https://codereview.appspot.com/13586043/diff/8001/src/pkg/sort/example_interf...
File src/pkg/sort/example_interface_test.go (right):

https://codereview.appspot.com/13586043/diff/8001/src/pkg/sort/example_interf...
src/pkg/sort/example_interface_test.go:18: // Age field
// the Age field.

(add the, add period)

https://codereview.appspot.com/13586043/diff/8001/src/pkg/sort/example_interf...
src/pkg/sort/example_interface_test.go:19: type ByAge []Person
Please make this a []*Person.
That's much more common, since if the struct is big you can avoid swapping the
data.

https://codereview.appspot.com/13586043/diff/8001/src/pkg/sort/example_interf...
src/pkg/sort/example_interface_test.go:36: // Output: [{Bob 31} {John 42}
{Michael 17} {Jenny 26}]
you can put this on the next line

// Output:
// [{Bob 31...
// [{Michael 17...

[cronos, 2013-09-07 06:21:04]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[taj, 2013-09-07 14:57:32]

in description, s/simplier/simpler/

On Friday, 6 September 2013 23:21:04 UTC-7, Andrew Lytvynov wrote:
>
> Hello golan...@googlegroups.com <javascript:>,
r...@golang.org<javascript:>(cc: 
> golan...@googlegroups.com <javascript:>), 
>
> Please take another look. 
>
>
> https://codereview.appspot.com/13586043/ 
>

[cronos, 2013-09-07 15:30:59]

On 2013/09/07 14:57:32, taj wrote:
> in description, s/simplier/simpler/
> 
> On Friday, 6 September 2013 23:21:04 UTC-7, Andrew Lytvynov wrote:
> >
> > Hello mailto:golan...@googlegroups.com <javascript:>,
> r...@golang.org<javascript:>(cc: 
> > mailto:golan...@googlegroups.com <javascript:>), 
> >
> > Please take another look. 
> >
> >
> > https://codereview.appspot.com/13586043/ 
> >

sorry, fixed.

[r, 2013-09-08 01:15:41]

LGTM

[r, 2013-09-08 01:17:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=61e731e2c738 ***

sort: add a simpler sort.Interface example

Existing example renamed to Example_sortWrapper.
Fixes issue 6335.

R=golang-dev, rsc, taj.khattra, r
CC=golang-dev
https://codereview.appspot.com/13586043

Committer: Rob Pike <r@golang.org>