Issue 135840043: code review 135840043: go-tour: add analytics to old tour.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 135840043: code review 135840043: go-tour: add analytics to old tour. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by francesc

Modified:
9 years, 7 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

[release-branch.go1.2] go-tour: add analytics to old tour.

Patch Set 1 #

Patch Set 2 : diff -r 43b701ccd766ab33c675551c068f8db60a8b4ad3 https://code.google.com/p/go-tour #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	js/tour.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

francesc

Hello adg (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 7 months ago (2014-08-27 02:45:31 UTC) #1

adg

Please put "[release-branch.go1.2]" at the start of the commit message

9 years, 7 months ago (2014-08-27 02:46:13 UTC) #2

francesc

On 2014/08/27 02:46:13, adg wrote: > Please put "[release-branch.go1.2]" at the start of the commit ...

9 years, 7 months ago (2014-08-27 02:47:25 UTC) #3

adg

Sorry, it should be like this: [release-branch.go1.2] go-tour: add analytics to old tour.

9 years, 7 months ago (2014-08-27 02:48:06 UTC) #4

francesc

On 2014/08/27 02:48:06, adg wrote: > Sorry, it should be like this: > > [release-branch.go1.2] ...

9 years, 7 months ago (2014-08-27 02:48:39 UTC) #5

francesc

9 years, 7 months ago (2014-08-27 02:51:04 UTC) #7

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=450551231b2d
***

[release-branch.go1.2] go-tour: add analytics to old tour.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/135840043

Expand All Messages | Collapse All Messages