code review 135820043: unicode: use go generate instead of make to create tables.go

unicode: use go generate instead of make to create tables.go

[r, 2014-08-26 17:55:34]

Hello mpvl, rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mpvl, 2014-08-26 19:13:16]

Cool.
LGTM, but one suggestion.

https://codereview.appspot.com/135820043/diff/1/src/pkg/unicode/letter.go
File src/pkg/unicode/letter.go (right):

https://codereview.appspot.com/135820043/diff/1/src/pkg/unicode/letter.go#new...
src/pkg/unicode/letter.go:11: //go:generate ./maketables --tables=all -output
tables.go
Any reason not to make it `go run maketables.go --tables=all -output tables.go`?

This way it won't leave a binary lingering.

[r, 2014-08-26 19:26:03]

not usually a fan of go run, but ok.

[r, 2014-08-26 19:26:15]

Hello mpvl@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[mpvl, 2014-08-26 19:38:03]

LGTM

[rsc, 2014-08-26 19:45:41]

LGTM

[r, 2014-08-26 21:43:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=0cf22b0a2756 ***

unicode: use go generate instead of make to create tables.go

LGTM=mpvl, rsc
R=mpvl, rsc
CC=golang-codereviews
https://codereview.appspot.com/135820043

[gobot, 2014-08-26 22:20:09]

This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/d5d787df4619b9d1986453fab34a6b11354fa125