Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1162)

Issue 135690043: code review 135690043: go.benchmark/garbage: fix garbage benchmark after pkg move

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dfc
Modified:
9 years, 6 months ago
Reviewers:
dvyukov
CC:
golang-codereviews, gobot, dvyukov
Visibility:
Public.

Description

go.benchmark/garbage: fix garbage benchmark after pkg move Second attempt to fix the benchmark so that it works for revisions pre and post the pkg move.

Patch Set 1 #

Patch Set 2 : diff -r f53d6ffd4ae23805c69dbdb66628d4f939c95d96 https://code.google.com/p/go.benchmarks #

Patch Set 3 : diff -r f53d6ffd4ae23805c69dbdb66628d4f939c95d96 https://code.google.com/p/go.benchmarks #

Total comments: 6

Patch Set 4 : diff -r f53d6ffd4ae23805c69dbdb66628d4f939c95d96 https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M garbage/garbage.go View 1 2 3 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 10
dfc
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.benchmarks
9 years, 6 months ago (2014-09-11 03:04:56 UTC) #1
gobot
R=dvyukov@google.com (assigned by dave@cheney.net)
9 years, 6 months ago (2014-09-11 03:11:28 UTC) #2
dvyukov
please test on linux/windows on new and old revisions it's really easy to break benchmarks ...
9 years, 6 months ago (2014-09-12 00:22:17 UTC) #3
dvyukov
Do you have access to a windows machine? I can help with testing. But please ...
9 years, 6 months ago (2014-09-12 19:14:13 UTC) #4
dfc
Sorry for the delay, I'll address your comments and test today. On 13 Sep 2014 ...
9 years, 6 months ago (2014-09-13 00:26:40 UTC) #5
dfc
Hello golang-codereviews@googlegroups.com, gobot@golang.org, dvyukov@google.com (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 6 months ago (2014-09-13 05:17:51 UTC) #6
dfc
Dmitry, I've made the changes you requested and testing this with the release and trunk ...
9 years, 6 months ago (2014-09-13 05:18:37 UTC) #7
dvyukov
LGTM
9 years, 6 months ago (2014-09-13 16:08:45 UTC) #8
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=17ba03832124&repo=benchmarks *** go.benchmark/garbage: fix garbage benchmark after pkg move Second attempt to ...
9 years, 6 months ago (2014-09-13 16:10:15 UTC) #9
dvyukov
9 years, 6 months ago (2014-09-13 16:11:13 UTC) #10
Thanks for fixing this!

On Sat, Sep 13, 2014 at 9:10 AM,  <dvyukov@google.com> wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=17ba03832124&repo=benchmarks
> ***
>
> go.benchmark/garbage: fix garbage benchmark after pkg move
>
> Second attempt to fix the benchmark so that it works for revisions pre
> and post the pkg move.
>
> LGTM=dvyukov
> R=golang-codereviews, gobot, dvyukov
> CC=golang-codereviews
> https://codereview.appspot.com/135690043
>
> Committer: Dmitriy Vyukov <dvyukov@google.com>
>
>
> https://codereview.appspot.com/135690043/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b