Issue 135610043: code review 135610043: ogle/program: return the PCs of the breakpoints set.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 135610043: code review 135610043: ogle/program: return the PCs of the breakpoints set. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by nigeltao

Modified:
9 years, 7 months ago

Reviewers:
r

CC:
r

Visibility:
Public.

Description

ogle/program: return the PCs of the breakpoints set.

Patch Set 1 #

Patch Set 2 : diff -r 983f81634c48d3b2474dd0c0105b0e5f951415e8 https://code.google.com/p/ogle #

Patch Set 3 : diff -r 983f81634c48d3b2474dd0c0105b0e5f951415e8 https://code.google.com/p/ogle #

Patch Set 4 : diff -r 983f81634c48d3b2474dd0c0105b0e5f951415e8 https://code.google.com/p/ogle #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
M	program/client/client.go	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	program/program.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	program/proxyrpc/proxyrpc.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	program/server/server.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r@golang.org, I'd like you to review this change to https://code.google.com/p/ogle

9 years, 7 months ago (2014-09-09 04:45:52 UTC) #1

nigeltao

9 years, 7 months ago (2014-09-09 06:30:46 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=72ea378d21c4 ***

ogle/program: return the PCs of the breakpoints set.

LGTM=r
R=r
https://codereview.appspot.com/135610043

Expand All Messages | Collapse All Messages