Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4733)

Issue 1354041: code review 1354041: release.2010-05-27 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by adg
Modified:
13 years, 11 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

release.2010-05-27

Patch Set 1 #

Patch Set 2 : code review 1354041: release.2010-05-27 #

Patch Set 3 : code review 1354041: release.2010-05-27 #

Total comments: 1

Patch Set 4 : code review 1354041: release.2010-05-27 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/release.html View 1 2 3 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 5
adg
Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 11 months ago (2010-05-27 23:23:57 UTC) #1
r2
LGTM maybe summarize the renamings in compress. -rob On May 27, 2010, at 4:23 PM, ...
13 years, 11 months ago (2010-05-27 23:33:48 UTC) #2
adg
Hello r, rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 11 months ago (2010-05-27 23:41:06 UTC) #3
r
LGTM http://codereview.appspot.com/1354041/diff/7001/8002 File doc/devel/release.html (right): http://codereview.appspot.com/1354041/diff/7001/8002#newcode73 doc/devel/release.html:73: * template: regularize name lookups of interfaces, pointers, ...
13 years, 11 months ago (2010-05-27 23:43:50 UTC) #4
adg
13 years, 11 months ago (2010-05-27 23:50:35 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=a85ad0a64015 ***

release.2010-05-27

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/1354041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b