code review 135280043: runtime: don't allocate a new string in snprintf

runtime: don't allocate a new string in snprintf

This fixes the Plan 9 build.

Fix issue 8621.

[0intro, 2014-09-02 12:28:56]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mattn, 2014-09-02 12:48:25]

Does it works well without race condition?

[0intro, 2014-09-02 13:03:24]

> Does it works well without race condition?

No, it never works. I'm not sure what would be the right fix.
This change works around the crash in gomallocgc by avoiding
the allocation.

The issue isn't even specific to Plan 9. It happens because
Plan 9 uses snprintf to build error strings. The other
systems never call snprintf.

[iant, 2014-09-02 13:33:53]

LGTM

[0intro, 2014-09-02 22:39:39]

Hello rsc@golang.org, mattn.jp@gmail.com, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[iant, 2014-09-02 22:46:47]

On 2014/09/02 22:39:39, 0intro wrote:
> Hello mailto:rsc@golang.org, mailto:mattn.jp@gmail.com, mailto:iant@golang.org
(cc:
> mailto:golang-codereviews@googlegroups.com),
> 
> Please take another look.

Did you change anything since the LGTM?  I don't see a difference.

Ian

[0intro, 2014-09-02 22:56:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=70fadda83be4 ***

runtime: don't allocate a new string in snprintf

This fixes the Plan 9 build.

Fix issue 8621.

LGTM=iant
R=rsc, mattn.jp, iant
CC=golang-codereviews
https://codereview.appspot.com/135280043

[0intro, 2014-09-02 22:59:47]

> Did you change anything since the LGTM?  I don't see a difference.

Sorry, wrong typing. Submitted now.

-- 
David du Colombier

[gobot, 2014-09-03 01:39:46]

This CL appears to have broken the linux-arm-panda builder.
See http://build.golang.org/log/388b304f2944942bb77e5da4b513e2c85b55d6ae